Tabulator: fix index out of bound error when updating table value with selected row and add_filter#7822
Open
thuydotm wants to merge 3 commits into
Open
Tabulator: fix index out of bound error when updating table value with selected row and add_filter#7822thuydotm wants to merge 3 commits into
thuydotm wants to merge 3 commits into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7822 +/- ##
===========================================
- Coverage 86.09% 70.28% -15.81%
===========================================
Files 349 348 -1
Lines 54734 54752 +18
===========================================
- Hits 47121 38482 -8639
- Misses 7613 16270 +8657 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently just a failing UI test to address #7525
Looks like the bug was in the
eventthat passed intoTabulator._reset_selection()method.