Skip to content

Add “tables” to the tests-deser extra#880

Merged
maximlt merged 3 commits into
holoviz:mainfrom
musicinmybrain:deser-tables
Nov 6, 2023
Merged

Add “tables” to the tests-deser extra#880
maximlt merged 3 commits into
holoviz:mainfrom
musicinmybrain:deser-tables

Conversation

@musicinmybrain
Copy link
Copy Markdown
Contributor

@musicinmybrain musicinmybrain commented Nov 3, 2023

Enables one additional test.

param/tests/testfiledeserialization.py

Lines 63 to 66 in b6a285b

try:
import tables as hdf5
except:
hdf5 = None

param/tests/testfiledeserialization.py

Line 76 in b6a285b

hdf5_skip = skipIf(hdf5 is None, "pytables is not available")

param/tests/testfiledeserialization.py

Lines 205 to 213 in b6a285b

@pd_skip
@hdf5_skip
def test_data_frame_hdf5(self):
path = '{}/val.h5'.format(self.temp_dir)
P.data_frame.to_hdf(path, 'df')
self._test_deserialize_array(P, path, 'data_frame')
path = '{}/val.hdf5'.format(self.temp_dir)
P.data_frame.to_hdf(path, 'df')
self._test_deserialize_array(P, path, 'data_frame')

@maximlt
Copy link
Copy Markdown
Member

maximlt commented Nov 6, 2023

tables is actually installed when the CI runs on Linux:

param/pyproject.toml

Lines 191 to 196 in e9b2781

# Only install gmpy on Linux on these version
# Only install tables (deser HDF5) on Linux on these version
matrix.python.dependencies = [
{ value = "gmpy", if = ["3.8", "3.9", "3.10"], platform = ["linux"] },
{ value = "tables", if = ["3.8", "3.9", "3.10", "3.11", "3.12"], platform = ["linux"] },
]

And you can verify the test is not skipped:
https://github.com/holoviz/param/actions/runs/6761543745/job/18376521753#step:7:595

It's just that the dependencies declaration is a little convoluted in pyproject.yml, and that in the end the tests-deser isn't used at all. I'll merge your PR though since anyway tables should be in tests-deser.

@maximlt maximlt merged commit c30ae02 into holoviz:main Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@musicinmybrain @maximlt