Bump async-upnp-client to 0.45.0 #148961
Bump async-upnp-client to 0.45.0 #148961
Conversation
|
Hey there @chishm, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
|
Hey there @chishm, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
|
Hey there @zewelor, @shenxn, @starkillerOG, @alexyao2015, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
|
Hey there @chemelli74, @epenet, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
There was a problem hiding this comment.
Pull Request Overview
Bump async-upnp-client to 0.45.0 to pick up SSDP header parsing fixes after the aiohttp upgrade.
- Update async-upnp-client version in test and production requirements and package constraints
- Update component manifests to require async-upnp-client==0.45.0 across SSDP and UPnP integrations
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| requirements_test_all.txt | Bump async-upnp-client from 0.44.0 to 0.45.0 |
| requirements_all.txt | Bump async-upnp-client from 0.44.0 to 0.45.0 |
| homeassistant/package_constraints.txt | Bump async-upnp-client from 0.44.0 to 0.45.0 |
| homeassistant/components/yeelight/manifest.json | Update async-upnp-client requirement |
| homeassistant/components/upnp/manifest.json | Update async-upnp-client requirement |
| homeassistant/components/ssdp/manifest.json | Update async-upnp-client requirement |
| homeassistant/components/samsungtv/manifest.json | Update async-upnp-client requirement |
| homeassistant/components/dlna_dms/manifest.json | Update async-upnp-client requirement |
| homeassistant/components/dlna_dmr/manifest.json | Update async-upnp-client requirement |
|
This feel like a weird almost breaking change in aiohttp @bdraco thoughts? |
|
Agreed. Not sure from what version aiohttp was bumped recently, patch or
minor. Not at a computer right now.
Point was that the SSDP status line (read: HTTP status line) was fed to the
header parsing. Earlier the line was ignored, now this raises an error.
|
|
Ah it's using HeaderParser object from the library. Unsure if that is considered public. Changes looks alright. |
|
Thanks! |
|
Breaking change in aiohttp was unavoidable and wasn't marked breaking at the time of publish because GHSA-9548-qrrj-x5pj was under embargo |
Proposed change
Bump async-upnp-client to 0.45.0, fixing parsing of SSDP headers after bumping aiohttp to 3.12.14.
This not only impacts the upnp component, but also the ssdp component and most likely components using the discovery via ssdp as well.
See:
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: