Skip to content

Conversation

@catsmanac
Copy link
Contributor

Proposed change

Enphase Integration is not canceling the mac verification background task when unloading. This PR adds canceling the task to async_unload_entry.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue: Enphase authentication loop #148028
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant
Copy link

home-assistant bot commented Jul 3, 2025

Hey there @bdraco, @cgarwood, @joostlek, mind taking a look at this pull request as it has been labeled with an integration (enphase_envoy) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of enphase_envoy can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign enphase_envoy Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@frenck frenck added this to the 2025.7.1 milestone Jul 3, 2025
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @catsmanac 👍

../Frenck

@frenck frenck merged commit 8ef6b62 into home-assistant:dev Jul 3, 2025
34 checks passed
@frenck frenck mentioned this pull request Jul 4, 2025
alexlebens pushed a commit to alexlebens/infrastructure that referenced this pull request Jul 5, 2025
…824)

This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [ghcr.io/home-assistant/home-assistant](https://www.home-assistant.io/) ([source](https://github.com/home-assistant/core)) | minor | `2025.6.3` -> `2025.7.1` |

---

### Release Notes

<details>
<summary>home-assistant/core (ghcr.io/home-assistant/home-assistant)</summary>

### [`v2025.7.1`](https://github.com/home-assistant/core/releases/tag/2025.7.1)

[Compare Source](home-assistant/core@2025.7.0...2025.7.1)

- Set timeout for remote calendar ([@&#8203;Thomas55555] - [#&#8203;147024]) ([remote\_calendar docs][remote_calendar docs])
- Fix missing port in samsungtv ([@&#8203;epenet] - [#&#8203;147962]) ([samsungtv docs])
- Bump ZHA to 0.0.62 ([@&#8203;puddly] - [#&#8203;147966]) ([zha docs]) (dependency)
- Bump aiounifi to v84 ([@&#8203;Kane610] - [#&#8203;147987]) ([unifi docs])
- Fix state being incorrectly reported in some situations on Music Assistant players ([@&#8203;marcelveldt] - [#&#8203;147997]) ([music\_assistant docs][music_assistant docs]) (dependency)
- Bump hass-nabucasa from 0.104.0 to 0.105.0 ([@&#8203;ludeeus] - [#&#8203;148040]) ([cloud docs]) (dependency)
- Fix Telegram bots using plain text parser failing to load on restart ([@&#8203;hanwg] - [#&#8203;148050]) ([telegram\_bot docs][telegram_bot docs])
- Bump pyenphase to 2.2.0 ([@&#8203;catsmanac] - [#&#8203;148070]) ([enphase\_envoy docs][enphase_envoy docs]) (dependency)
- Cancel enphase mac verification on unload. ([@&#8203;catsmanac] - [#&#8203;148072]) ([enphase\_envoy docs][enphase_envoy docs])
- Bump aioamazondevices to 3.2.3 ([@&#8203;chemelli74] - [#&#8203;148082]) ([alexa\_devices docs][alexa_devices docs]) (dependency)
- Update frontend to [`2025070`](https://github.com/home-assistant/core/commit/20250702).1 ([@&#8203;bramkragten] - [#&#8203;148131]) ([frontend docs]) (dependency)
- \[ci] Fix typing issue with aiohttp and aiosignal ([@&#8203;cdce8p] - [#&#8203;148141]) ([http docs])
- Bump venstarcolortouch to 0.21 ([@&#8203;mlfreeman2] - [#&#8203;148152]) ([venstar docs]) (dependency)

[#&#8203;147024]: home-assistant/core#147024

[#&#8203;147533]: home-assistant/core#147533

[#&#8203;147962]: home-assistant/core#147962

[#&#8203;147966]: home-assistant/core#147966

[#&#8203;147987]: home-assistant/core#147987

[#&#8203;147997]: home-assistant/core#147997

[#&#8203;148040]: home-assistant/core#148040

[#&#8203;148050]: home-assistant/core#148050

[#&#8203;148070]: home-assistant/core#148070

[#&#8203;148072]: home-assistant/core#148072

[#&#8203;148082]: home-assistant/core#148082

[#&#8203;148131]: home-assistant/core#148131

[#&#8203;148141]: home-assistant/core#148141

[#&#8203;148152]: home-assistant/core#148152

[@&#8203;Kane610]: https://github.com/Kane610

[@&#8203;Thomas55555]: https://github.com/Thomas55555

[@&#8203;bramkragten]: https://github.com/bramkragten

[@&#8203;catsmanac]: https://github.com/catsmanac

[@&#8203;cdce8p]: https://github.com/cdce8p

[@&#8203;chemelli74]: https://github.com/chemelli74

[@&#8203;epenet]: https://github.com/epenet

[@&#8203;frenck]: https://github.com/frenck

[@&#8203;hanwg]: https://github.com/hanwg

[@&#8203;ludeeus]: https://github.com/ludeeus

[@&#8203;marcelveldt]: https://github.com/marcelveldt

[@&#8203;mlfreeman2]: https://github.com/mlfreeman2

[@&#8203;puddly]: https://github.com/puddly

[abode docs]: https://www.home-assistant.io/integrations/abode/

[adax docs]: https://www.home-assistant.io/integrations/adax/

[aemet docs]: https://www.home-assistant.io/integrations/aemet/

[agent_dvr docs]: https://www.home-assistant.io/integrations/agent_dvr/

[ai_task docs]: https://www.home-assistant.io/integrations/ai_task/

[alexa_devices docs]: https://www.home-assistant.io/integrations/alexa_devices/

[cloud docs]: https://www.home-assistant.io/integrations/cloud/

[enphase_envoy docs]: https://www.home-assistant.io/integrations/enphase_envoy/

[frontend docs]: https://www.home-assistant.io/integrations/frontend/

[http docs]: https://www.home-assistant.io/integrations/http/

[music_assistant docs]: https://www.home-assistant.io/integrations/music_assistant/

[remote_calendar docs]: https://www.home-assistant.io/integrations/remote_calendar/

[samsungtv docs]: https://www.home-assistant.io/integrations/samsungtv/

[telegram_bot docs]: https://www.home-assistant.io/integrations/telegram_bot/

[unifi docs]: https://www.home-assistant.io/integrations/unifi/

[venstar docs]: https://www.home-assistant.io/integrations/venstar/

[zha docs]: https://www.home-assistant.io/integrations/zha/

### [`v2025.7.0`](https://github.com/home-assistant/core/releases/tag/2025.7.0)

[Compare Source](home-assistant/core@2025.6.3...2025.7.0)

https://www.home-assistant.io/blog/2025/07/02/release-20257/

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0MS4xLjMiLCJ1cGRhdGVkSW5WZXIiOiI0MS4xLjMiLCJ0YXJnZXRCcmFuY2giOiJtYWluIiwibGFiZWxzIjpbImltYWdlIl19-->

Reviewed-on: https://gitea.alexlebens.dev/alexlebens/infrastructure/pulls/824
Co-authored-by: Renovate Bot <renovate-bot@alexlebens.net>
Co-committed-by: Renovate Bot <renovate-bot@alexlebens.net>
@github-actions github-actions bot locked and limited conversation to collaborators Jul 5, 2025
@catsmanac catsmanac deleted the enphase_end_mac_task branch July 6, 2025 20:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants