Skip to content

Conversation

@funkybunch
Copy link
Contributor

@funkybunch funkybunch commented Jul 5, 2025

Proposed change

Version bump sharkiq to 1.1.1 - this upgrade to 1.1.1 includes:

  • Patch for new auth flow
  • Adds new statuses for mop/vacuum combination units

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant
Copy link

home-assistant bot commented Jul 5, 2025

Hey there @JeffResc, mind taking a look at this pull request as it has been labeled with an integration (sharkiq) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of sharkiq can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign sharkiq Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

Copy link
Contributor

@JeffResc JeffResc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@funkybunch
Copy link
Contributor Author

funkybunch commented Jul 6, 2025

Switched PR type from Dependency upgrade to bug fix, because the reason for the dependency upgrade is fixing a production bug

Note on tests - the tests that are failing are from another integration. Please advise if action is necessary on our end, but I see these same tests failing on other PRs that were recently merged.

@zweckj zweckj added this to the 2025.7.2 milestone Jul 7, 2025
@zweckj zweckj changed the title Version bump sharkiq Bump sharkiq to 1.1.1 Jul 7, 2025
@zweckj zweckj changed the title Bump sharkiq to 1.1.1 Bump sharkiq to 1.1.1 Jul 7, 2025
@zweckj
Copy link
Member

zweckj commented Jul 7, 2025

test failures unrelated

@zweckj zweckj merged commit e4c9df6 into home-assistant:dev Jul 7, 2025
42 of 44 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jul 8, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SharkIQ Suspicious request requires verification

4 participants