Handle binary coils with non default mappings in nibe heatpump #148354
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joostlek
requested changes
Jul 7, 2025
| 'friendly_name': 'F1255 EB101 Installed', | ||
| }), | ||
| 'context': <ANY>, | ||
| 'entity_id': 'binary_sensor.eb101_installed_49239', |
There was a problem hiding this comment.
There are many strange one: https://github.com/yozik04/nibe/blob/master/nibe/data/f1155_f1255.json eb101 is a type of asscessory. The number is the ID of the data in nibe databases.
Since we have no way on entities to show what their source unique identifies are in gui (to map to offical documentations) it kinda need to go somewhere.
Comment on lines
66
to
105
| async def test_turn_on( | ||
| hass: HomeAssistant, | ||
| mock_connection: AsyncMock, | ||
| model: Model, | ||
| entity_id: str, | ||
| address: int, | ||
| state: Any, | ||
| coils: dict[int, Any], | ||
| ) -> None: | ||
| """Test setting of value.""" | ||
| coils[address] = state | ||
|
|
||
| await async_add_model(hass, model) | ||
|
|
||
| await hass.async_block_till_done() | ||
| assert hass.states.get(entity_id) | ||
|
|
||
| # Write value | ||
| await hass.services.async_call( | ||
| PLATFORM_DOMAIN, | ||
| SERVICE_TURN_ON, | ||
| {ATTR_ENTITY_ID: entity_id}, | ||
| blocking=True, | ||
| ) | ||
|
|
||
| await hass.async_block_till_done() | ||
|
|
||
| # Verify written | ||
| args = mock_connection.write_coil.call_args | ||
| assert args | ||
| coil = args.args[0] | ||
| assert isinstance(coil, CoilData) | ||
| assert coil.coil.address == address | ||
| assert coil.raw_value == 1 | ||
|
|
||
|
|
||
| @pytest.mark.parametrize( | ||
| ("model", "address", "entity_id", "state"), | ||
| [ | ||
| (Model.F1255, 48043, "switch.holiday_activated_48043", "INACTIVE"), | ||
| (Model.F1255, 48071, "switch.flm_1_accessory_48071", "ON"), | ||
| ], | ||
| ) | ||
| @pytest.mark.usefixtures("entity_registry_enabled_by_default") | ||
| async def test_turn_off( |
There was a problem hiding this comment.
If you feel fancy, you could also parametrize these
There was a problem hiding this comment.
Well. i would have to parametrize the service call. Feels ugly.
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
029d2af to
783d81a
Compare
783d81a to
baf691e
Compare
joostlek
approved these changes
Jul 8, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Handle the case of binary sensors and switches not using default mapping off "ON", "OFF".
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: