Skip to content

Conversation

@zweckj
Copy link
Member

@zweckj zweckj commented Jul 8, 2025

Breaking change

Proposed change

https://github.com/zweckj/pylamarzocco/releases/tag/v2.0.11
zweckj/pylamarzocco@v2.0.10...v2.0.11

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

Copilot AI review requested due to automatic review settings July 8, 2025 06:47
@zweckj zweckj added this to the 2025.7.2 milestone Jul 8, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the pylamarzocco dependency to version 2.0.11 across requirements and manifest, and adjusts the binary sensor logic to handle the new BackFlushStatus.CLEANING state.

  • Bump pylamarzocco from 2.0.10 to 2.0.11 in requirements_all.txt, requirements_test_all.txt, and manifest.json.
  • Update LaMarzoccoBinarySensorEntityDescription to treat CLEANING as an active back-flush request.

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
requirements_test_all.txt Upgraded pylamarzocco test dependency to 2.0.11
requirements_all.txt Upgraded pylamarzocco runtime dependency to 2.0.11
homeassistant/components/lamarzocco/manifest.json Updated manifest requirement for pylamarzocco==2.0.11
homeassistant/components/lamarzocco/binary_sensor.py Expanded back-flush status check to include CLEANING state
Comments suppressed due to low confidence (1)

homeassistant/components/lamarzocco/binary_sensor.py:69

  • Consider adding a unit test for the new CLEANING state to ensure the binary sensor correctly reports as on when BackFlushStatus.CLEANING is returned.
            in (BackFlushStatus.REQUESTED, BackFlushStatus.CLEANING)

@joostlek joostlek merged commit d2bf271 into home-assistant:dev Jul 8, 2025
43 of 44 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jul 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants