Add diagnostics to UISP AirOS #149631
Add diagnostics to UISP AirOS #149631
Conversation
|
|
||
| from .coordinator import AirOSConfigEntry | ||
|
|
||
| IP_REDACT = ["addr", "ipaddr", "ip6addr", "lastip"] # IP related |
There was a problem hiding this comment.
why are you redacting private IP addresses? IMO that's not really sensitive data
There was a problem hiding this comment.
It can disclose someones network at home, which might be very beneficial to those inclined to do harm, also I don't see why IP addresses would be helpful, and if, one can decide to disclose themselves?
| TO_REDACT_HA = [CONF_HOST, CONF_PASSWORD] | ||
| TO_REDACT_AIROS = [ | ||
| "device_id", | ||
| "hostname", # Prevent leaking device naming |
There was a problem hiding this comment.
if you redact all those, isn't it a bit difficult to even clearly identify the individual devices?
There was a problem hiding this comment.
To some extent, though as these are primarily distance devices, they might contain building names potentially disclosing information. As for the device_id's that indeed is less of an issue, I'll strike them from redaction.
Proposed change
Add diagnostics, including redaction, to UISP AirOS integration. Note/question, username - defaulting to
ubntis not redacted at this time.Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: