Make _EventDeviceRegistryUpdatedData_Remove JSON serializable #149734
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR makes the _EventDeviceRegistryUpdatedData_Remove event data JSON serializable by changing the device field from a DeviceEntry object to a dictionary representation. This addresses serialization issues when device removal events are fired.
Key changes:
- Updated the
devicefield type annotation fromDeviceEntrytodict[str, Any]in the TypedDict - Modified the event firing code to use
device.dict_reprinstead of the raw device object - Updated all test assertions to expect the dictionary representation
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| homeassistant/helpers/device_registry.py | Updated TypedDict definition and event firing to use device dictionary representation |
| homeassistant/helpers/entity_registry.py | Updated event handler to work with dictionary representation instead of DeviceEntry object |
| tests/helpers/test_device_registry.py | Updated test assertions to expect device.dict_repr in event data |
Comments suppressed due to low confidence (1)
homeassistant/helpers/entity_registry.py:1106
- [nitpick] The variable name
removed_device_dictis verbose and inconsistent with the originalremoved_device. Consider renaming toremoved_deviceto maintain consistency while clearly indicating it's now a dictionary through the type annotation.
removed_device_dict = event.data["device"]
MartinHjelmare
approved these changes
Jul 31, 2025
bramkragten
pushed a commit
that referenced
this pull request
Jul 31, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Make
_EventDeviceRegistryUpdatedData_RemoveEvents JSON serializableType of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: