Fix tuya light supported color modes #149793
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey there @tuya, @zlinoliver, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue with Tuya light supported color modes where lights that don't actually support color were incorrectly showing WHITE as a supported color mode. The fix ensures that if a light supports WHITE mode but not actual color capabilities, the WHITE mode is removed from the supported color modes.
- Fixes incorrect color mode support detection for Tuya lights
- Adds logic to remove WHITE color mode when color is not actually supported
- Includes new test fixture and snapshots for a solar flood light device
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| homeassistant/components/tuya/light.py | Adds logic to filter out WHITE color mode when color is not supported |
| tests/components/tuya/init.py | Adds test configuration for new solar flood light device |
| tests/components/tuya/fixtures/tyndj_pyakuuoc.json | New test fixture for solar flood light device |
| tests/components/tuya/snapshots/test_light.ambr | Updated test snapshots showing brightness-only color mode |
| tests/components/tuya/snapshots/test_sensor.ambr | Updated test snapshots for battery sensors |
| tests/components/tuya/snapshots/test_switch.ambr | Updated test snapshots for energy saving switch |
emontnemery
reviewed
Aug 1, 2025
emontnemery
approved these changes
Aug 1, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Linked to #149704
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: