Fix Z-Wave handling of driver ready event #149879
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey there @home-assistant/z-wave, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
There was a problem hiding this comment.
Pull Request Overview
This PR fixes Z-Wave handling of driver ready events by ensuring config entries are reloaded when receiving a driver ready event from external sources (like Z-Wave JS UI). Previously, the integration only listened for driver ready events during specific operations like controller hard reset or NVM restore within Home Assistant.
- Adds a global listener for driver ready events to reload config entries and clean stored client state
- Consolidates driver ready event handling logic into a reusable helper function
- Updates test expectations to reflect the new approach where config entry reloads happen automatically
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
homeassistant/components/zwave_js/__init__.py |
Adds global driver ready event listener to automatically reload config entries |
homeassistant/components/zwave_js/helpers.py |
Adds new helper function for waiting on driver ready events and config entry reloads |
homeassistant/components/zwave_js/const.py |
Moves DRIVER_READY_TIMEOUT constant to helpers.py as DRIVER_READY_EVENT_TIMEOUT |
homeassistant/components/zwave_js/config_flow.py |
Updates to use new helper function for driver ready event handling |
homeassistant/components/zwave_js/api.py |
Updates hard reset and NVM restore operations to use new helper function |
tests/components/zwave_js/test_init.py |
Adds test for driver ready event handling |
tests/components/zwave_js/test_config_flow.py |
Updates tests to use new constant location and adjusted call counts |
tests/components/zwave_js/test_api.py |
Refactors tests to use proper async mocks and updated constant references |
joostlek
approved these changes
Aug 3, 2025
bramkragten
pushed a commit
that referenced
this pull request
Aug 4, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: