Skip to content

Airthings ContextVar warning #149930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 4, 2025
Merged

Airthings ContextVar warning #149930

merged 1 commit into from
Aug 4, 2025

Conversation

@LaStrada
Copy link
Contributor

@LaStrada LaStrada commented Aug 4, 2025

Breaking change

Proposed change

Adding a config_entry to the coordinator

2025-07-30 09:44:10.459 WARNING (MainThread) [homeassistant.helpers.frame] Detected that integration 'airthings' relies on ContextVar, but should pass the config entry explicitly. at homeassistant/components/airthings/coordinator.py, line 22: super().__init__(. This will stop working in Home Assistant 2026.8, please create a bug report at https://github.com/home-assistant/core/issues?q=is%3Aopen+is%3Aissue+label%3A%22integration%3A+airthings%

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes ContextVar warning - AirThings #149766
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

Copilot AI review requested due to automatic review settings August 4, 2025 08:51
@home-assistant
Copy link

home-assistant bot commented Aug 4, 2025

Hey there @Danielhiversen, mind taking a look at this pull request as it has been labeled with an integration (airthings) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of airthings can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign airthings Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

Copilot AI reviewed Aug 4, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a deprecation warning in the Airthings integration by adding explicit config_entry parameter handling to address Home Assistant's move away from ContextVar usage.

  • Updates the AirthingsDataUpdateCoordinator constructor to accept a config_entry parameter
  • Passes the config_entry explicitly to the parent DataUpdateCoordinator class
  • Moves the AirthingsConfigEntry type definition from __init__.py to coordinator.py for better organization

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
homeassistant/components/airthings/coordinator.py Adds config_entry parameter to coordinator constructor and defines AirthingsConfigEntry type
homeassistant/components/airthings/init.py Updates coordinator instantiation to pass config_entry and removes duplicate type definition

homeassistant/components/airthings/coordinator.py
Comment on lines +17 to 19
type AirthingsConfigEntry = ConfigEntry[AirthingsDataUpdateCoordinator]


Copy link

Copilot AI Aug 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The type alias creates a circular reference where AirthingsConfigEntry is defined in terms of AirthingsDataUpdateCoordinator, but AirthingsDataUpdateCoordinator also uses AirthingsConfigEntry in its constructor. Consider using ConfigEntry directly in the constructor parameter or defining the type alias after the class definition.

Suggested change
type AirthingsConfigEntry = ConfigEntry[AirthingsDataUpdateCoordinator]

Copilot uses AI. Check for mistakes.
@joostlek joostlek added this to the 2025.8.0 milestone Aug 4, 2025
@joostlek joostlek merged commit 6fa9d42 into home-assistant:dev Aug 4, 2025
31 checks passed
@LaStrada LaStrada deleted the airthings-contextvar-warning branch August 4, 2025 10:23
@github-actions github-actions bot locked and limited conversation to collaborators Aug 5, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

Copilot code review Copilot Copilot left review comments

@joostlek joostlek joostlek approved these changes

@Danielhiversen Danielhiversen Awaiting requested review from Danielhiversen Danielhiversen is a code owner

Assignees

@Danielhiversen Danielhiversen

Labels

bugfix by-code-owner cherry-picked cla-signed integration: airthings Quality Scale: No score small-pr PRs with less than 30 lines.

Projects

None yet

Milestone

2025.8.0

Development

Successfully merging this pull request may close these issues.

ContextVar warning - AirThings

4 participants

@LaStrada @joostlek @frenck @Danielhiversen