Skip to content

Pass config entry to Remote Calendar coordinator #149958

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 4, 2025
Merged

Pass config entry to Remote Calendar coordinator #149958

merged 1 commit into from
Aug 4, 2025

Conversation

@joostlek
Copy link
Member

@joostlek joostlek commented Aug 4, 2025 •
edited by edenhaus
Loading

Proposed change

Pass config entry to Remote Calendar coordinator

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@joostlek joostlek added this to the 2025.8.0 milestone Aug 4, 2025
Copilot AI review requested due to automatic review settings August 4, 2025 10:01
@joostlek joostlek requested a review from allenporter as a code owner August 4, 2025 10:01
@home-assistant
Copy link

home-assistant bot commented Aug 4, 2025

Hey there @Thomas55555, @allenporter, mind taking a look at this pull request as it has been labeled with an integration (remote_calendar) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of remote_calendar can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign remote_calendar Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

Copilot AI reviewed Aug 4, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a bug by passing the config entry to the Remote Calendar coordinator's initialization. This ensures the coordinator has proper access to the config entry, which is now a recommended practice in Home Assistant's DataUpdateCoordinator.

@Thomas55555 Thomas55555 mentioned this pull request Aug 4, 2025
Closed
@Thomas55555
Copy link
Contributor

Thomas55555 commented Aug 4, 2025

Can we reference #149739 to close the issue automatically?

@edenhaus edenhaus merged commit 0bdf675 into home-assistant:dev Aug 4, 2025
34 checks passed
frenck pushed a commit that referenced this pull request Aug 5, 2025
@joostlek @frenck
Pass config entry to Remote Calendar coordinator (#149958)
a06557e
@github-actions github-actions bot locked and limited conversation to collaborators Aug 6, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

Copilot code review Copilot Copilot left review comments

@edenhaus edenhaus edenhaus approved these changes

@allenporter allenporter Awaiting requested review from allenporter allenporter is a code owner

+1 more reviewer

@Thomas55555 Thomas55555 Thomas55555 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@allenporter allenporter

Labels

bugfix cherry-picked cla-signed integration: remote_calendar Quality Scale: silver small-pr PRs with less than 30 lines.

Projects

None yet

Milestone

2025.8.0

Development

Successfully merging this pull request may close these issues.

Deprecation warning for Remote Calendar in 2025.8.0b0 beta

5 participants

@joostlek @Thomas55555 @edenhaus @frenck @allenporter