Skip to content

Bump icalendar from 6.1.0 to 6.3.1 for CalDav #149990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 5, 2025
Merged

Bump icalendar from 6.1.0 to 6.3.1 for CalDav #149990

merged 1 commit into from
Aug 5, 2025

Conversation

@grzesjam
Copy link
Contributor

@grzesjam grzesjam commented Aug 4, 2025 •
edited
Loading

Proposed change

Bump icalendar module from 6.1.0 to 6.3.1.

This is needed for upcoming PR allowing adding and removing events from CalDav calendar.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

There is a bug in 6.1.0 version where rrule causes iteration errors for no reason. It got fixed in 6.2.0.

Changelog: https://icalendar.readthedocs.io/en/latest/changelog.html#id1

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

Copilot AI review requested due to automatic review settings August 4, 2025 17:33
home-assistant[bot]
home-assistant bot previously requested changes Aug 4, 2025
View reviewed changes
Copy link

@home-assistant home-assistant bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @grzesjam

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@home-assistant home-assistant bot marked this pull request as draft August 4, 2025 17:33
@home-assistant
Copy link

home-assistant bot commented Aug 4, 2025

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

Copilot AI reviewed Aug 4, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR upgrades the icalendar dependency from version 6.1.0 to 6.2.0 for the CalDav integration. The upgrade addresses a bug in 6.1.0 where rrule causes iteration errors and prepares for upcoming functionality to add and remove events from CalDav calendars.

Key changes:

  • Updated icalendar dependency version from 6.1.0 to 6.2.0 across all requirement files
  • Modified the CalDav integration manifest to reflect the new dependency version

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
requirements_test_all.txt Updated icalendar version for test dependencies
requirements_all.txt Updated icalendar version for all dependencies
homeassistant/components/caldav/manifest.json Updated icalendar requirement in CalDav integration manifest

@grzesjam grzesjam marked this pull request as ready for review August 4, 2025 17:37
@pioto
Copy link
Contributor

pioto commented Aug 4, 2025

Why not update to the slightly more recent 6.3.1 version?

https://icalendar.readthedocs.io/en/latest/changelog.html#id1

frenck
frenck approved these changes Aug 5, 2025
View reviewed changes
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @grzesjam 👍

../Frenck

@frenck frenck added this to the 2025.8.0 milestone Aug 5, 2025
@grzesjam
Copy link
Contributor Author

grzesjam commented Aug 5, 2025 •
edited
Loading

Hello @frenck, Thanks for approve
CI failed on MQTT tests, something I didn't touch, I have rebased my branch, can you approve it again?

@pioto why not latest? It's my first PR and change to HA and I want to introduce the least amount of changes.

@frenck
Copy link
Member

frenck commented Aug 5, 2025

Hello @frenck, Thanks for approve CI failed on MQTT tests, something I didn't touch, I have rebased my branch, can you approve it again?

Done

@pioto why not latest? It's my first PR and change to HA and I want to introduce the least amount of changes.

Yet, those versions contain fixed. The amount of changes introduced in HA would be the same?

@grzesjam
Bump icalendar from 6.1.0 to 6.3.1
bd5bede 
Version 6.1.0 has due to a bug where rrule caused iteration errors.
@grzesjam grzesjam force-pushed the caldav-bump-icalendar branch from 0cd66c6 to bd5bede Compare August 5, 2025 08:06
@grzesjam grzesjam changed the title Bump icalendar from 6.1.0 to 6.2.0 for CalDav Bump icalendar from 6.1.0 to 6.3.1 for CalDav Aug 5, 2025
@grzesjam
Copy link
Contributor Author

grzesjam commented Aug 5, 2025

@frenck
Most of the development I did on 6.2.0, but it seems like 6.3.1 also works fine and there are no regressions.
I have upgraded icalendar to 6.3.1 and changed PR text to say so.

frenck
frenck approved these changes Aug 5, 2025
View reviewed changes
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @grzesjam 👍

../Frenck

@grzesjam
Copy link
Contributor Author

grzesjam commented Aug 5, 2025

@frenck
This time another test run failed in ezviz which I made no changes to.
Can you restart that check?

@edenhaus
Copy link
Member

edenhaus commented Aug 5, 2025

Test failure unrelated

@edenhaus edenhaus merged commit 7dd761c into home-assistant:dev Aug 5, 2025
43 of 44 checks passed
frenck pushed a commit that referenced this pull request Aug 5, 2025
@grzesjam @frenck
Bump icalendar from 6.1.0 to 6.3.1 for CalDav (#149990)
74c2549
@github-actions github-actions bot locked and limited conversation to collaborators Aug 6, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

Copilot code review Copilot Copilot left review comments

@frenck frenck frenck approved these changes

@home-assistant home-assistant[bot] home-assistant[bot] left review comments

Assignees

No one assigned

Labels

cherry-picked cla-signed dependency integration: caldav Quality Scale: No score small-pr PRs with less than 30 lines.

Projects

None yet

Milestone

2025.8.0

Development

Successfully merging this pull request may close these issues.

4 participants

@grzesjam @pioto @frenck @edenhaus