Skip to content

Conversation

@hanwg
Copy link
Contributor

@hanwg hanwg commented Jul 20, 2025

Proposed change

When registering a webhook bot, a secret is generated and a HomeAssistantView is created.
If the user defined multiple webhook bots, this results in a "Invalid secret token from x.x.x.x" error as different secrets are registered to the same url.

This change appends the bot id to the url to avoid conflicts so that there are multiple views each with its distinct url and associated secret token.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

Copy link
Contributor

@chemelli74 chemelli74 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@MartinHjelmare MartinHjelmare added this to the 2025.7.4 milestone Jul 22, 2025
@MartinHjelmare MartinHjelmare merged commit 42cf4e8 into home-assistant:dev Jul 22, 2025
34 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jul 23, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Telegram commands and text not working after HA2025.07

5 participants