Add Z-Wave USB migration confirm step #149243
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey there @home-assistant/z-wave, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
MartinHjelmare
commented
Jul 22, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR adds a confirmation step to the Z-Wave USB discovery flow when migrating from an existing adapter to a new one. Previously, users were taken directly to the NVM backup progress without any context about what was happening.
Key changes:
- Adds a new confirmation step that explains the migration process before proceeding
- Updates the flow to show users what will happen when migrating to a new Z-Wave USB adapter
- Provides better user experience by giving context before starting the migration
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
homeassistant/components/zwave_js/config_flow.py |
Adds new async_step_confirm_usb_migration method and updates USB flow to use it |
homeassistant/components/zwave_js/strings.json |
Adds UI strings for the new confirmation step |
tests/components/zwave_js/test_config_flow.py |
Updates existing tests to handle the new confirmation step |
MindFreeze
approved these changes
Jul 22, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
Add a confirmation step when the user starts a USB discovery flow with an existing config entry which will lead to the migration flow.
We removed the general USB discovery confirm step a while ago, but didn't consider the case that leads to the migration flow. There's now no context for the user what's happening, but they are dumped directly in the NVM backup progress. Add the confirmation step to explain what will happen if the user proceeds with the flow.
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: