Skip to content

Conversation

@gaaf
Copy link
Contributor

@gaaf gaaf commented Jul 24, 2025

Proposed change

Upgrade slixmpp to 1.10.0

https://codeberg.org/poezio/slixmpp/releases

This fixes bug #141757 (for me), although I don't know exactly what change in slixmmp has caused it to be fixed...

Type of change

NOTE: Please, check only 1! box!

This makes no sense as the dependency upgrade fixes a bug. This can't be split, so how to choose?

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @fabaff, @flowolf, mind taking a look at this pull request as it has been labeled with an integration (xmpp) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of xmpp can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign xmpp Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@gaaf
Copy link
Contributor Author

gaaf commented Jul 24, 2025

I don't see how the failed test are even remotely related to the changes in this PR.

edit: Indeed, tests pass after a force-push.

@gaaf gaaf force-pushed the xmpp-upgrade-slixmpp branch from 5162af8 to 3d8f83e Compare July 24, 2025 12:42
@frenck
Copy link
Member

frenck commented Jul 27, 2025

This makes no sense as the dependency upgrade fixes a bug. This can't be split, so how to choose?

This is not a bug fix on this end, so it is a dependency upgrade.

@frenck frenck added this to the 2025.7.4 milestone Jul 27, 2025
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @gaaf 👍

../Frenck

@frenck frenck merged commit a33760b into home-assistant:dev Jul 27, 2025
47 of 48 checks passed
frenck pushed a commit that referenced this pull request Jul 27, 2025
@frenck frenck mentioned this pull request Jul 27, 2025
wollew pushed a commit to wollew/hacore that referenced this pull request Jul 28, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Jul 28, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Detected blocking call to load_verify_locations with args (<ssl.SSLContext object at 0x7f1b2253cb00>,)

3 participants