Hey there @fabaff, @flowolf, mind taking a look at this pull request as it has been labeled with an integration (xmpp) you are listed as a code owner for? Thanks!

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

Hi, @frenck ! I did manually test that before my two-line change, unencrypted XMPP servers no longer work, and after my two-line change, they work again. Is there other specific testing that you would like to see? Perhaps I could temporarily configure an encrypted XMPP server to ensure that encrypted connections do not regress with this change? That would still be a manual test, of course.

I was able to manually test this as follows:

I kept my legacy non-TLS XMPP config, which works with my PR:

  - name: low_priority
    platform: xmpp
    sender: low@xmpp
    password: !secret jabber_password
    recipient: igo@xmpp
    tls: False

I set up an account on a public encrypted XMPP server and added two configurations for it:

  - name: jabberx_no_enc
    platform: xmpp
    sender: bob@jabberx.net
    password: !secret jabberx_password
    recipient: bob@jabberx.net
    tls: False

and

  - name: jabberx_enc
    platform: xmpp
    sender: bob@jabberx.net
    password: !secret jabberx_password
    recipient: bob@jabberx.net
    tls: True

My expectation of a successful test would be that the mis-configured jabberx_no_enc would not allow sending messages, but the properly-configured jabberx_enc would. Indeed this is what happens when I try to use each of those.

I hope this manual test suffices.