Skip to content

Conversation

@starkillerOG
Copy link
Contributor

Breaking change

Proposed change

Adjust wifi_connection to function according to the version bump

Bump reolink-aio to 0.14.6:
Breaking changes

Additions:

Bug fixes:

Optimizations:

Full Changelog: starkillerOG/reolink_aio@0.14.5...0.14.6

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR bumps the reolink-aio library dependency from version 0.14.5 to 0.14.6 and adapts the code to handle a breaking change where wifi_connection was changed from a property to a function in the updated library.

Key Changes

  • Update reolink-aio dependency version in requirements files
  • Convert wifi_connection property access to function calls throughout the codebase
  • Add additional condition check in diagnostics for WiFi signal reporting

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
requirements_test_all.txt Bump reolink-aio version from 0.14.5 to 0.14.6
requirements_all.txt Bump reolink-aio version from 0.14.5 to 0.14.6
homeassistant/components/reolink/sensor.py Convert wifi_connection property to function call in sensor supported check
homeassistant/components/reolink/manifest.json Update reolink-aio requirement version in manifest
homeassistant/components/reolink/diagnostics.py Convert wifi_connection property to function call and add WiFi connection check for signal reporting

@starkillerOG starkillerOG added this to the 2025.8.0 milestone Aug 5, 2025
@zweckj zweckj merged commit 12dca4b into home-assistant:dev Aug 5, 2025
43 of 44 checks passed
@starkillerOG starkillerOG deleted the reolink_bump0146 branch August 5, 2025 19:30
frenck pushed a commit that referenced this pull request Aug 6, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Aug 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants