Fix zero-argument functions with as_function #150062
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug in the as_function helper that prevented it from working with zero-argument functions. The issue was that the wrapper function incorrectly expected a required value parameter, making it impossible to call macros that don't need any arguments.
- Removes the required
valueparameter from theas_functionwrapper - Updates the macro call to not pass the removed
valueparameter - Adds test coverage for zero-argument function scenarios
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| homeassistant/helpers/template.py | Fixes the as_function wrapper to support zero-argument functions by removing the required value parameter |
| tests/helpers/test_template.py | Adds test case to verify as_function works correctly with zero-argument macros |
Comments suppressed due to low confidence (1)
tests/helpers/test_template.py:853
- [nitpick] The macro name
macro_get_hellois redundant since it's already a macro. Consider renaming to justget_hellofor clarity.
{%- macro macro_get_hello(returns) -%}
edenhaus
approved these changes
Aug 6, 2025
|
test failure unrelated |
frenck
pushed a commit
that referenced
this pull request
Aug 6, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
Fixes an issue with
as_functionthat prevented it from working with 0-argument functions.Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: