Fix KNX BinarySensor config_store data #151808
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey there @Julius2342, @marvin-w, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a data migration issue in the KNX integration where the respond_to_read configuration field was incorrectly included in binary sensor configurations. The field was never valid for binary sensors but was being set as a default in earlier schema versions.
- Removes invalid
respond_to_readfield from binary sensor configurations during migration - Updates storage schema from version 2.1 to 2.2 to handle this cleanup
- Adds comprehensive test coverage for the new migration functionality
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| homeassistant/components/knx/storage/config_store.py | Updates storage version to 2.2 and adds migration logic for cleaning binary sensor configs |
| homeassistant/components/knx/storage/migration.py | Implements new migration function to remove invalid respond_to_read field from binary sensors |
| tests/components/knx/test_config_store.py | Adds test case for the 2.1 to 2.2 migration |
| tests/components/knx/fixtures/config_store_binarysensor_v2_1.json | New test fixture with the problematic respond_to_read field |
| tests/components/knx/fixtures/config_store_binarysensor.json | Updated to version 2.2 with respond_to_read field removed |
| tests/components/knx/fixtures/config_store_light.json | Updated minor version to 2.2 for consistency |
jabari-max
approved these changes
Sep 6, 2025
thecode
approved these changes
Sep 6, 2025
marvin-w
approved these changes
Sep 6, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
"respond_to_read" was never used for binary_sensor and is not valid in the new schema. It was set as default in v1 and v2.1
Having the invalid key in the config data prevents users from editing config as validation fails.
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: