Skip to content

Fix KNX Light - individual color initialisation from UI config #151815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 12, 2025
Merged

Fix KNX Light - individual color initialisation from UI config #151815

merged 2 commits into from
Sep 12, 2025
+34 −28

Conversation

@farmio
Copy link
Contributor

@farmio farmio commented Sep 6, 2025 •
edited
Loading

Proposed change

  • Individual color lights configured in UI were wrongly initialised. The config parameters of blue and green weren't sourced from subkey and thus ignored.
  • Fix selector order of individual color configuration to have consistent switch, brightness order for all colours.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

Copilot AI review requested due to automatic review settings September 6, 2025 08:47
@farmio farmio requested a review from marvin-w as a code owner September 6, 2025 08:47
Copilot AI reviewed Sep 6, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Fixes incorrect configuration parameter sourcing for KNX light individual color components configured through the UI. Blue and green color channel parameters were not being read from the correct configuration subkey, causing them to be ignored during initialization.

Key Changes

  • Corrected blue and green color channel configuration parameter sourcing to use the CONF_COLOR subkey
  • Updated four parameter calls to consistently use the proper configuration hierarchy

@home-assistant
Copy link

home-assistant bot commented Sep 6, 2025

Hey there @Julius2342, @marvin-w, mind taking a look at this pull request as it has been labeled with an integration (knx) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of knx can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign knx Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@farmio farmio added this to the 2025.9.2 milestone Sep 6, 2025
frenck
frenck approved these changes Sep 12, 2025
View reviewed changes
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @farmio 👍

../Frenck

@frenck frenck merged commit 64ba437 into dev Sep 12, 2025
34 checks passed
@frenck frenck deleted the knx-fix-light-indi branch September 12, 2025 08:43
frenck pushed a commit that referenced this pull request Sep 12, 2025
@farmio @frenck
Fix KNX Light - individual color initialisation from UI config (#151815)
64ec460
@frenck frenck mentioned this pull request Sep 12, 2025
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Sep 13, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

Copilot code review Copilot Copilot left review comments

@frenck frenck frenck approved these changes

@marvin-w marvin-w Awaiting requested review from marvin-w marvin-w is a code owner

Assignees

@marvin-w marvin-w

Labels

bugfix by-code-owner cherry-picked cla-signed integration: knx Quality Scale: silver small-pr PRs with less than 30 lines.

Projects

None yet

Milestone

2025.9.2

Development

Successfully merging this pull request may close these issues.

4 participants

@farmio @frenck @marvin-w