Skip to content

Conversation

@martinssipenko
Copy link
Contributor

Proposed change

Bump pysmarty2 version to 0.10.3

Diff: martinssipenko/pysmarty2@v0.10.2...v0.10.3

This solves #151644 by enabling compatibility with pymodbus 3.11.x

Fixes #151644

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

Copilot AI review requested due to automatic review settings September 7, 2025 05:59
@home-assistant
Copy link

home-assistant bot commented Sep 7, 2025

Hey there @z0mbieprocess, mind taking a look at this pull request as it has been labeled with an integration (smarty) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of smarty can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign smarty Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the pysmarty2 library dependency from version 0.10.2 to 0.10.3 to fix compatibility issues with pymodbus 3.11.x, resolving issue #151644.

  • Updates pysmarty2 dependency version to 0.10.3 across all requirement files
  • Enables compatibility with newer pymodbus versions
  • Fixes existing functionality without introducing breaking changes

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
requirements_test_all.txt Updates pysmarty2 version for test dependencies
requirements_all.txt Updates pysmarty2 version for production dependencies
homeassistant/components/smarty/manifest.json Updates pysmarty2 version requirement in smarty integration manifest

@jpbede jpbede added this to the 2025.9.2 milestone Sep 7, 2025
@jpbede jpbede merged commit 7f8b5f2 into home-assistant:dev Sep 7, 2025
48 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Sep 8, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Salda Smarty integration doesn't work with version 2025.9.0

4 participants