Skip to content

Add motion presets to SmartThings AC #153830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 6, 2025
Merged

Add motion presets to SmartThings AC #153830

merged 1 commit into from
Oct 6, 2025
+261 −182

Conversation

@joostlek
Copy link
Member

@joostlek joostlek commented Oct 6, 2025

Proposed change

Add motion presets to SmartThings AC

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@joostlek joostlek added this to the 2025.10.2 milestone Oct 6, 2025
Copilot AI review requested due to automatic review settings October 6, 2025 11:20
Copilot AI reviewed Oct 6, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for motion presets to the SmartThings AC integration by adding two new motion-related preset modes.

Reviewed Changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.

Show a summary per file
File Description
homeassistant/components/smartthings/climate.py Adds mapping for motionIndirect and motionDirect preset modes
homeassistant/components/smartthings/strings.json Adds translations for the new motion preset modes
tests/components/smartthings/test_climate.py Updates entity ID and device ID in preset mode test
tests/components/smartthings/snapshots/*.ambr Updates entity names, IDs, and values to reflect new test fixture data
tests/components/smartthings/fixtures/devices/da_ac_rac_000003.json Updates device fixture with new device ID, label, and supported capabilities
tests/components/smartthings/fixtures/device_status/da_ac_rac_000003.json Updates device status fixture with new values including motion presets in supported modes

@zweckj zweckj merged commit 5ad805d into home-assistant:dev Oct 6, 2025
34 checks passed
@NoRi2909
Copy link
Contributor

NoRi2909 commented Oct 6, 2025

Can you give me a hint what these two modes mean in an air conditioner unit?

I have no idea how to translate this.

@mbo18
Copy link
Contributor

mbo18 commented Oct 6, 2025

Can you give me a hint what these two modes mean in an air conditioner unit?

I have no idea how to translate this.

Hi @NoRi2909 check this video about these 2 modes: https://www.youtube.com/watch?v=hkaDTC6qfzo

@NoRi2909
Copy link
Contributor

NoRi2909 commented Oct 6, 2025

@mbo18 Thanks for the quick hint, now it's clear. :-)

Also found some explanation in the user manual based on this:

image

I've added comments in Lokalise to help other translators here, too.

@github-actions github-actions bot locked and limited conversation to collaborators Oct 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

Copilot code review Copilot Copilot left review comments

@zweckj zweckj zweckj approved these changes

Assignees

No one assigned

Labels

bugfix by-code-owner cherry-picked cla-signed Hacktoberfest has-tests integration: smartthings Quality Scale: bronze small-pr PRs with less than 30 lines.

Projects

None yet

Milestone

2025.10.2

Development

Successfully merging this pull request may close these issues.

Unknown preset mode: motionIndirect and motionDirect

5 participants

@joostlek @NoRi2909 @mbo18 @zweckj @frenck