Skip to content

Conversation

@chemelli74
Copy link
Contributor

Breaking change

Proposed change

Fix restore cover state for Comelit SimpleHome

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request:

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes the cover state restoration functionality for the Comelit SimpleHome integration by properly restoring the last known state when Home Assistant restarts.

  • Removes tracking of intermediate state strings and replaces with proper action state restoration
  • Updates the state restoration logic to set the correct _last_action and _attr_is_closed attributes
  • Simplifies the test to verify state restoration using parameterized test cases

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
homeassistant/components/comelit/cover.py Updates state restoration logic to properly restore cover position and action states
tests/components/comelit/test_cover.py Simplifies and parameterizes the cover state restoration test

@chemelli74
Copy link
Contributor Author

Thx !

@chemelli74 chemelli74 merged commit 994a6ae into home-assistant:dev Oct 7, 2025
34 checks passed
@chemelli74 chemelli74 deleted the chemelli74-comelit-cover branch October 7, 2025 07:07
@github-actions github-actions bot locked and limited conversation to collaborators Oct 8, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants