`sharkiq` dependency bump to 1.4.2 #153931

Freebien · 2025-10-07T14:47:51Z

Proposed change

Fixing authentication for Europe by using Auth0 and using library version 1.4.2.

Here is the release for the sharkiq library that has been updated : https://github.com/sharkiqlibs/sharkiq/releases/tag/v1.4.2

Type of change

Dependency upgrade
Bugfix (non-breaking change which fixes an issue)
New integration (thank you!)
New feature (which adds functionality to an existing integration)
Deprecation (breaking change to happen in the future)
Breaking change (fix/feature causing existing functionality to break)
Code quality improvements to existing code or addition of tests

Additional information

This PR fixes or closes issue: fixes SharkIQ: No state returned from /authorize #152339
This PR is related to issue:
Link to documentation pull request:
Link to developer documentation pull request:
Link to frontend pull request:

Checklist

I understand the code I am submitting and can explain how it works.
The code change is tested and works locally.
Local tests pass. Your PR cannot be merged unless tests pass
There is no commented out code in this PR.
I have followed the development checklist
I have followed the perfect PR recommendations
The code has been formatted using Ruff (ruff format homeassistant tests)
Tests have been added to verify that the new code works.
Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

The manifest file has all fields filled out correctly.
Updated and included derived files by running: python3 -m script.hassfest.
New or updated dependencies have been added to requirements_all.txt.
Updated by running python3 -m script.gen_requirements_all.
For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

I have reviewed two other open pull requests in this repository.

Fixing authentication for Europe by using Auth0 and using library version 1.4.1

home-assistant

Hi @Freebien

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

home-assistant · 2025-10-07T14:47:56Z

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

home-assistant · 2025-10-07T14:48:00Z

Hey there @JeffResc, @funkybunch, mind taking a look at this pull request as it has been labeled with an integration (sharkiq) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of sharkiq can trigger bot actions by commenting:

@home-assistant close Closes the pull request.
@home-assistant rename Awesome new title Renames the pull request.
@home-assistant reopen Reopen the pull request.
@home-assistant unassign sharkiq Removes the current integration label and assignees on the pull request, add the integration domain after the command.
@home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
@home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

Stale

funkybunch · 2025-10-07T18:43:09Z

@home-assistant rename sharkiq dependency bump to 1.4.1

funkybunch · 2025-10-07T18:59:12Z

homeassistant/components/sharkiq/__init__.py

        async with asyncio.timeout(API_TIMEOUT):
            LOGGER.debug("Initialize connection to Ayla networks API")
-            await ayla_api.async_sign_in()
+            await ayla_api.async_sign_in(True)


@Freebien forcing True here will force an authentication method that will break the integration for users outside of the EU. We may need another upstream dependency update to work around this.

Could you test out this PR locally and let me know if it works for you without any parameters in the ayla_api.async_sign_in() method?

Just tested the PR and it works as intended !

This should be better indeed. I didn't thought it would break for outside the EU.

@Freebien just cut a new release for the upstream library. If you remove this Boolean in both places and update your PR to 1.4.2 of the dependency then you can reopen the issue and I’ll approve.

Or @joostlek are you saying that the expected behavior is for 2nd level dependencies to not show up in requirements_all.txt?

If that’s the case the I’ll submit approval and no further changes will be needed.

funkybunch · 2025-10-07T19:00:08Z

@home-assistant add-label needs-more-information

abmantis · 2025-10-07T22:18:31Z

Marking this as draft. Pease mark it as ready when the concerns raised are addressed.
Thanks! :)

Rollback to before async_sign_in(True) to allow non EU users to authent

funkybunch · 2025-10-08T13:12:07Z

@home-assistant remove-label needs-more-information

homeassistant/components/sharkiq/manifest.json

funkybunch

Thanks @Freebien!

funkybunch · 2025-10-10T02:01:01Z

@Freebien when you have a moment could you please update your link to the release notes in the PR description to 1.4.2?

Thanks!

Freebien · 2025-10-10T04:08:20Z

@Freebien when you have a moment could you please update your link to the release notes in the PR description to 1.4.2?

Thanks!

Done !
Sorry about that ^^

Fix sharkiq authentication

3cbb680

Fixing authentication for Europe by using Auth0 and using library version 1.4.1

home-assistant bot previously requested changes Oct 7, 2025

View reviewed changes

home-assistant bot added bugfix cla-needed dependency Hacktoberfest integration: sharkiq small-pr PRs with less than 30 lines. labels Oct 7, 2025

home-assistant bot marked this pull request as draft October 7, 2025 14:47

home-assistant bot added the Quality Scale: No score label Oct 7, 2025

home-assistant bot added cla-recheck cla-signed and removed cla-recheck cla-needed labels Oct 7, 2025

Freebien marked this pull request as ready for review October 7, 2025 14:51

home-assistant bot changed the title ~~Fix sharkiq authentication~~ sharkiq dependency bump to 1.4.1 Oct 7, 2025

funkybunch suggested changes Oct 7, 2025

View reviewed changes

home-assistant bot added the needs-more-information label Oct 7, 2025

abmantis marked this pull request as draft October 7, 2025 22:17

Freebien added 2 commits October 8, 2025 12:38

Fix to allow non EU users to authentify

bbad9c1

Rollback to before async_sign_in(True) to allow non EU users to authent

sharkiq dependency bump to 1.4.2

864ec85

home-assistant bot removed the needs-more-information label Oct 8, 2025

Freebien changed the title ~~sharkiq dependency bump to 1.4.1~~ sharkiq dependency bump to 1.4.2 Oct 8, 2025

Freebien marked this pull request as ready for review October 8, 2025 13:13

home-assistant bot requested a review from funkybunch October 8, 2025 13:13

funkybunch reviewed Oct 8, 2025

View reviewed changes

homeassistant/components/sharkiq/manifest.json Show resolved Hide resolved

funkybunch approved these changes Oct 8, 2025

View reviewed changes

Freebien requested a review from joostlek October 9, 2025 12:13

zweckj added this to the 2025.10.2 milestone Oct 10, 2025

zweckj approved these changes Oct 10, 2025

View reviewed changes

zweckj merged commit 1e192aa into home-assistant:dev Oct 10, 2025
48 checks passed

chemelli74 pushed a commit to chemelli74/core that referenced this pull request Oct 10, 2025

sharkiq dependency bump to 1.4.2 (home-assistant#153931)

91f04cf

frenck added the cherry-picked label Oct 10, 2025

frenck pushed a commit that referenced this pull request Oct 10, 2025

sharkiq dependency bump to 1.4.2 (#153931)

e6c2e0a

frenck mentioned this pull request Oct 10, 2025

2025.10.2 #154181

Merged

github-actions bot locked and limited conversation to collaborators Oct 11, 2025

Uh oh!

sharkiq dependency bump to 1.4.2 #153931

sharkiq dependency bump to 1.4.2 #153931

Uh oh!

Conversation

Freebien commented Oct 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed change

Type of change

Additional information

Checklist

Uh oh!

home-assistant bot left a comment

Choose a reason for hiding this comment

Uh oh!

home-assistant bot commented Oct 7, 2025

Uh oh!

home-assistant bot commented Oct 7, 2025

Uh oh!

funkybunch commented Oct 7, 2025

Uh oh!

funkybunch Oct 7, 2025

Choose a reason for hiding this comment

Uh oh!

Freebien Oct 8, 2025

Choose a reason for hiding this comment

Uh oh!

funkybunch Oct 8, 2025

Choose a reason for hiding this comment

Uh oh!

funkybunch Oct 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

funkybunch commented Oct 7, 2025

Uh oh!

abmantis commented Oct 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

funkybunch commented Oct 8, 2025

Uh oh!

Uh oh!

funkybunch left a comment

Choose a reason for hiding this comment

Uh oh!

funkybunch commented Oct 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Freebien commented Oct 10, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

`sharkiq` dependency bump to 1.4.2 #153931

`sharkiq` dependency bump to 1.4.2 #153931

Freebien commented Oct 7, 2025 •

edited

Loading

funkybunch Oct 8, 2025 •

edited

Loading

abmantis commented Oct 7, 2025 •

edited

Loading

funkybunch commented Oct 10, 2025 •

edited

Loading