Skip to content

Conversation

@TheJulianJES
Copy link
Member

Proposed change

This fixes an issue where trying to set up Home Assistant hardware (ZBT or Yellow) for Thread on a system not running Home Assistant OS leads to a corrupted message.

The message is adjusted to no longer display the docs_web_flasher_url, which wasn't even provided in the first place. We no longer need to show this, as the hardware integration installs OpenThread firmware in the step before this.

Users running a non-Home Assistant OS system will only need to set up a OpenThread border router container themselves. This is reflected by adding/keeping "manually" in the shown message (for setting up OTBR).

Open to suggestions if we want to adjust the message further.
I don't think we can (nor should) link the user anything on how to configure OTBR themselves though.

Before:

image

After:

Bildschirmfoto 2025-10-07 um 17 10 14

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request:

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

Copilot AI review requested due to automatic review settings October 7, 2025 15:21
@TheJulianJES TheJulianJES requested a review from a team as a code owner October 7, 2025 15:21
@home-assistant
Copy link

home-assistant bot commented Oct 7, 2025

Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration (homeassistant_hardware) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of homeassistant_hardware can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign homeassistant_hardware Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a broken error message in the Home Assistant hardware configuration flow for Thread setup on non-Home Assistant OS systems. The message was displaying a placeholder for a web flasher URL that wasn't being provided, resulting in a corrupted display.

Key Changes

  • Removed reference to non-existent web flasher URL from error message
  • Simplified the message to focus on manual OpenThread Border Router setup
  • Maintained clear guidance for users on non-HAOS systems

@TheJulianJES TheJulianJES merged commit 1a744a2 into home-assistant:dev Oct 10, 2025
48 checks passed
@TheJulianJES TheJulianJES deleted the tjj/ha_hardware_thread_haos_string branch October 10, 2025 09:37
@TheJulianJES TheJulianJES added this to the 2025.10.2 milestone Oct 10, 2025
@frenck frenck mentioned this pull request Oct 10, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Oct 11, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants