Skip to content

Bump aioasuswrt to 1.5.1 #153209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 13, 2025
Merged

Bump aioasuswrt to 1.5.1 #153209

merged 3 commits into from
Oct 13, 2025
+7 −8

Conversation

@kennedyshead
Copy link
Contributor

@kennedyshead kennedyshead commented Sep 29, 2025 •
edited
Loading

Proposed change

Stability bump of aioasuswrt.

ENDFUTURE

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description. changelog release-1.5.0 release-1.5.1

To help with the load of incoming pull requests:

@home-assistant
Copy link

home-assistant bot commented Sep 29, 2025

Hey there @ollo69, @Vaskivskyi, mind taking a look at this pull request as it has been labeled with an integration (asuswrt) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of asuswrt can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign asuswrt Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@kennedyshead kennedyshead force-pushed the aioasuswrt-1.5.0 branch 3 times, most recently from a269a7a to f6edeca Compare September 29, 2025 16:14
@epenet epenet changed the title Bump aioasuswrt version Bump aioasuswrt to 1.5.0 Sep 29, 2025
@abmantis
Copy link
Member

abmantis commented Sep 29, 2025

Hey @kennedyshead . The CI is failing on asuswrt tests. Can you take a look please?

@abmantis abmantis marked this pull request as draft September 29, 2025 17:16
@kennedyshead kennedyshead changed the title Bump aioasuswrt to 1.5.0 Bump aioasuswrt to 1.5.1 Sep 29, 2025
@kennedyshead kennedyshead marked this pull request as ready for review September 29, 2025 22:45
@joostlek
Copy link
Member

joostlek commented Sep 30, 2025

So 2 things:

  1. Why do we actually remove them?
  2. Do you have Discord and should we spin up a project channel so we can easily discuss changes?

@kennedyshead
Copy link
Contributor Author

kennedyshead commented Sep 30, 2025

So 2 things:

  1. Why do we actually remove them?
  2. Do you have Discord and should we spin up a project channel so we can easily discuss changes?
  1. They are broken :)
  • They also where calculated inside of aioasuswrt in a very "hacky" way.
  • All cache is removed from aioasuswrt so this means there is not a good way to do this anymore (this is related to devices never changing state).
  1. Yes ofc :) I am in the homeassistant DC from about 5min ago kennedyshead

@kennedyshead kennedyshead mentioned this pull request Oct 1, 2025
Closed
@kennedyshead kennedyshead force-pushed the aioasuswrt-1.5.0 branch 3 times, most recently from f3b507e to 9b86154 Compare October 12, 2025 07:09
@kennedyshead kennedyshead marked this pull request as draft October 12, 2025 07:24
@kennedyshead kennedyshead force-pushed the aioasuswrt-1.5.0 branch 2 times, most recently from 6341387 to a6ca16d Compare October 12, 2025 07:36
@kennedyshead kennedyshead marked this pull request as ready for review October 12, 2025 07:37
@kennedyshead
Copy link
Contributor Author

kennedyshead commented Oct 12, 2025

``

So 2 things:

  1. Why do we actually remove them?
  2. Do you have Discord and should we spin up a project channel so we can easily discuss changes?
  1. They are broken :)
  • They also where calculated inside of aioasuswrt in a very "hacky" way.
  • All cache is removed from aioasuswrt so this means there is not a good way to do this anymore (this is related to devices never changing state).
  1. Yes ofc :) I am in the homeassistant DC from about 5min ago kennedyshead

The removal is now removed from this PR

@kennedyshead
Copy link
Contributor Author

kennedyshead commented Oct 12, 2025

Will try to trigger the bot to relabel with close and reopen 🤷 Not really sure how it checks these things, but as I removed the breaking change the label should be removed.

@kennedyshead
Copy link
Contributor Author

kennedyshead commented Oct 12, 2025

@home-assistant reopen

@home-assistant home-assistant bot reopened this Oct 12, 2025
@kennedyshead
Copy link
Contributor Author

kennedyshead commented Oct 12, 2025

Nope 🤣 i guess he dont care 😁

joostlek
joostlek approved these changes Oct 13, 2025
View reviewed changes
Copy link
Member

@joostlek joostlek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kennedyshead/aioasuswrt@V1.4.0...v1.5.1

@joostlek joostlek added this to the 2025.10.3 milestone Oct 13, 2025
@joostlek joostlek merged commit 3a71087 into home-assistant:dev Oct 13, 2025
48 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Oct 14, 2025
@kennedyshead kennedyshead deleted the aioasuswrt-1.5.0 branch October 15, 2025 07:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@joostlek joostlek joostlek approved these changes

+1 more reviewer

@Sander0542 Sander0542 Sander0542 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

bugfix by-code-owner cherry-picked cla-signed dependency integration: asuswrt Quality Scale: No score small-pr PRs with less than 30 lines.

Projects

None yet

Milestone

2025.10.3

5 participants

@kennedyshead @abmantis @joostlek @Sander0542 @frenck