Z-Wave: ESPHome discovery to update all options #154113
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey there @home-assistant/z-wave, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
There was a problem hiding this comment.
Pull Request Overview
The PR updates Z-Wave JS ESPHome discovery handling to properly update config entries and add-on configurations without relying on config entry reloads. Instead of depending on reloading to sync add-on options to the config entry data, it now directly updates the config entry data and ensures the add-on is stopped before making configuration changes.
- Adds direct config entry data updates when handling ESPHome discovery for existing entries
- Stops running add-on before updating configuration to ensure clean state transitions
- Updates test to verify the new behavior with proper mocking
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| homeassistant/components/zwave_js/config_flow.py | Adds add-on state checking, stopping logic, and direct config entry updates for ESPHome discovery |
| tests/components/zwave_js/test_config_flow.py | Updates test fixture and adds assertions to verify new add-on stopping and config entry update behavior |
kbx81
approved these changes
Oct 9, 2025
chemelli74
pushed a commit
to chemelli74/core
that referenced
this pull request
Oct 10, 2025
frenck
pushed a commit
that referenced
this pull request
Oct 10, 2025
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
When Z-Wave JS handles an ESPHome discovery, now make sure we update the config entry and add-on config. No longer rely on reloading the config entry to set it up, because the add-on might not be in a known state.
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: