Skip to content

Remove redudant state write in Smart Meter Texas #154126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 11, 2025
Merged

Remove redudant state write in Smart Meter Texas #154126

merged 2 commits into from
Oct 11, 2025

Conversation

@srirams
Copy link
Contributor

@srirams srirams commented Oct 10, 2025

Proposed change

Remove redundant call to update state. async_write_ha_state() is already called in BaseCoordinatorEntity.

This extra call results in a duplicate EVENT_STATE_REPORTED.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request:

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant
Copy link

home-assistant bot commented Oct 10, 2025

Hey there @grahamwetzler, mind taking a look at this pull request as it has been labeled with an integration (smart_meter_texas) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of smart_meter_texas can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign smart_meter_texas Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

joostlek
joostlek reviewed Oct 10, 2025
View reviewed changes
Copy link
Member

@joostlek joostlek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mind if I push back a bit?

  1. Does the API still take 30 seconds to respond?
  2. Should we remove the separate listener and use _handle_coordinator_update instead?

@srirams
Copy link
Contributor Author

srirams commented Oct 10, 2025

Thank you for taking a look!

  1. I'm not sure. It's certainly not the most reliable, as it does show "Unavailable" at least once, if not more, a day. I haven't really taken a deep look at the api or the parent package itself. I don't think the redundant async_write_ha_state help in this as they are always called in sequence a few ms apart.

  2. You are absolutely correct and in addition the initial pull request would have resulted in the state being off by one update cycle. I have updated it, would appreciate feedback.

@srirams srirams requested a review from joostlek October 10, 2025 21:46
@joostlek
Copy link
Member

joostlek commented Oct 11, 2025

That would be fixed now. The thing is that there is an inheritance issue here and we'd like a bit of help to fix this :)

# pylint: disable-next=hass-invalid-inheritance # needs fixing
class SmartMeterTexasSensor(CoordinatorEntity, RestoreEntity, SensorEntity):

So if you'd be able to help us, we'd be very grateful :)

@joostlek
Copy link
Member

joostlek commented Oct 11, 2025

And the reason it is a RestoreEntity (which means it will restore a snapshot of a previous state) is because the startup might take too long and that the first update might come later. Hence I am wondering if it still takes 30s, otherwise we can remove that logic and make it "normal"

@joostlek joostlek changed the title remove redudant call to update state Remove redudant state write in Smart Meter Texas Oct 11, 2025
@joostlek joostlek merged commit a58a706 into home-assistant:dev Oct 11, 2025
34 checks passed
@joostlek joostlek added this to the 2025.10.3 milestone Oct 11, 2025
@srirams srirams deleted the smart-meter-texas-patch branch October 11, 2025 15:01
@github-actions github-actions bot locked and limited conversation to collaborators Oct 12, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@joostlek joostlek joostlek approved these changes

Assignees

No one assigned

Labels

bugfix cherry-picked cla-signed Hacktoberfest integration: smart_meter_texas Quality Scale: No score small-pr PRs with less than 30 lines.

Projects

None yet

Milestone

2025.10.3

Development

Successfully merging this pull request may close these issues.

3 participants

@srirams @joostlek @frenck