Skip to content

Conversation

@thecode
Copy link
Member

@thecode thecode commented Oct 10, 2025

Proposed change

Fix bug introduced due to #139008, when device closes the connection we push an update from aioshelly to notify listeners that the device is disconnected/unavailable, this causes an exception since we try to access data from the device:

Traceback (most recent call last):
  File "/usr/local/lib/python3.13/site-packages/aioshelly/rpc_device/wsrpc.py", line 391, in _rx_msgs
    self._on_notification(RPCSource.CLIENT, NOTIFY_WS_CLOSED, None)
    ~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  ...
  File "/usr/src/homeassistant/homeassistant/components/shelly/cover.py", line 229, in _update_callback
    if self.is_closing or self.is_opening:
       ^^^^^^^^^^^^^^^
  File "/usr/src/homeassistant/homeassistant/components/shelly/cover.py", line 198, in is_closing
    return cast(bool, self.status["state"] == "closing")
                      ^^^^^^^^^^^
  File "/usr/src/homeassistant/homeassistant/components/shelly/entity.py", line 433, in status
    return cast(dict, self.coordinator.device.status[self.key])
                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.13/site-packages/aioshelly/rpc_device/device.py", line 558, in status
    raise NotInitialized
aioshelly.exceptions.NotInitialized

I reviewed other places and this is the only problematic case.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request:

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@thecode thecode added this to the 2025.10.2 milestone Oct 10, 2025
Copilot AI review requested due to automatic review settings October 10, 2025 13:32
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Fixes a bug where Shelly RPC cover entities would crash with NotInitialized exception when the device connection is closed. The issue occurs when the device pushes an update notification after closing the connection, causing the entity to try accessing device status data that's no longer available.

  • Added early return in _update_callback when device is not initialized
  • Added test case to verify the fix handles uninitialized device updates properly

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
homeassistant/components/shelly/cover.py Added initialization check in _update_callback to prevent accessing device status when not available
tests/components/shelly/test_cover.py Added test case and import for STATE_UNAVAILABLE to verify proper handling of uninitialized device updates

@home-assistant
Copy link

Hey there @bieniu, @chemelli74, @bdraco, mind taking a look at this pull request as it has been labeled with an integration (shelly) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of shelly can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign shelly Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

Copy link
Contributor

@chemelli74 chemelli74 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thecode
Copy link
Member Author

thecode commented Oct 10, 2025

Thanks for the fast review

@thecode thecode merged commit 1001da0 into home-assistant:dev Oct 10, 2025
34 checks passed
@frenck frenck mentioned this pull request Oct 10, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Oct 11, 2025
@thecode thecode deleted the fix-shelly-cover-update branch October 18, 2025 12:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants