Move URL out of Switcher strings.json #154240
Merged
+11
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey there @YogevBokobza, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the Switcher integration's configuration flow to move a hardcoded documentation URL out of the translatable strings.json file and into a constant, making it non-translatable as intended.
- Extracts hardcoded URL from translatable string to a constant
- Uses placeholder interpolation to inject the URL into the description
- Applies the change to both credentials and reauth_confirm flow steps
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
homeassistant/components/switcher_kis/strings.json |
Replaces hardcoded URL with placeholder {prerequisites_url} |
homeassistant/components/switcher_kis/const.py |
Adds PREREQUISITES_URL constant for the documentation URL |
homeassistant/components/switcher_kis/config_flow.py |
Imports the constant and provides it via description_placeholders in both flow steps |
jbouwh
approved these changes
Oct 11, 2025
44 tasks
joostlek
approved these changes
Oct 11, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Move URL out of Switcher strings.json to avoid making it translatable
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: