Remove URL from ViCare strings.json #154243
Merged
+13
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joostlek
approved these changes
Oct 11, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR removes hardcoded URLs from translatable strings in the ViCare integration and moves them to configuration placeholders for better maintainability and localization. The change ensures URLs are not part of translatable content while still being accessible through templating.
- Extracts hardcoded Viessmann developer portal URL into a constant
- Updates configuration flow to use description placeholders for URL substitution
- Replaces inline URL in strings.json with placeholder reference
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
homeassistant/components/vicare/strings.json |
Removes hardcoded URL from description and data_description, adds placeholder reference |
homeassistant/components/vicare/entity.py |
Updates to use constant for configuration URL instead of hardcoded string |
homeassistant/components/vicare/const.py |
Adds new constant for Viessmann developer portal URL |
homeassistant/components/vicare/config_flow.py |
Adds description_placeholders to both user and reauth_confirm steps |
| VICARE_NAME = "ViCare" | ||
| VICARE_TOKEN_FILENAME = "vicare_token.save" | ||
|
|
||
| VIESSMANN_DEVELOPER_PORTAL = "https://app.developer.viessmann-climatesolutions.com" |
There was a problem hiding this comment.
The URL differs from the original URL in strings.json ('https://app.developer.viessmann.com' vs 'https://app.developer.viessmann-climatesolutions.com'). This could be a breaking change if the original URL was correct. Please verify this is the intended URL update.
Suggested change
| VIESSMANN_DEVELOPER_PORTAL = "https://app.developer.viessmann-climatesolutions.com" | |
| VIESSMANN_DEVELOPER_PORTAL = "https://app.developer.viessmann.com" |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Remove URL to developer portal form translatable string and into
description_placeholders.Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: