-
-
Notifications
You must be signed in to change notification settings - Fork 35.8k
Update Snoo strings.json to include weaning_baseline #154268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Lash-L/python-snoo#44 updates `SnooLevels` to include `weaning_baseline`, but there's no corresponding string here, so HA just shows the raw "weaning_baseline" value. This adds "Baseline (Weaning)" as a human-readable string for that enum value.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
|
Hey there @Lash-L, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
|
Given that this is for the Snoo integration, CC @Lash-L (and let me know if there's any changes you'd like me to make or any local testing that would be helpful here). Edit: oops didn't know the bot would CC you, sorry for the double-CC. |
Proposed change
Right now, the Snoo integration has a state value (
weaning_baseline) that doesn't have a human-readable string associated with it, so it shows up to the end-user in that form. This adds a human-readable string for that value.Type of change
Additional information
Lash-L/python-snoo#44 updates
SnooLevelsto includeweaning_baseline, but there's no corresponding string here, so HA just shows the raw "weaning_baseline" value (see attached image).So this PR adds "Baseline (Weaning)" as a human-readable string for that enum value. I'm open to alternative translations here, this seemed to match what I would expect.
If there's a clean way to test this locally, let me know; given that it's a strings-only change, though, it seems like it should be pretty safe.
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: