Skip to content

Conversation

@dschafer
Copy link
Contributor

Proposed change

Right now, the Snoo integration has a state value (weaning_baseline) that doesn't have a human-readable string associated with it, so it shows up to the end-user in that form. This adds a human-readable string for that value.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Lash-L/python-snoo#44 updates SnooLevels to include weaning_baseline, but there's no corresponding string here, so HA just shows the raw "weaning_baseline" value (see attached image).

IMG_0434

So this PR adds "Baseline (Weaning)" as a human-readable string for that enum value. I'm open to alternative translations here, this seemed to match what I would expect.

If there's a clean way to test this locally, let me know; given that it's a strings-only change, though, it seems like it should be pretty safe.

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

Lash-L/python-snoo#44 updates `SnooLevels` to include `weaning_baseline`, but there's no corresponding string here, so HA just shows the raw "weaning_baseline" value.

This adds "Baseline (Weaning)" as a human-readable string for that enum value.
Copy link

@home-assistant home-assistant bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @dschafer

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft October 12, 2025 03:23
@home-assistant
Copy link

Hey there @Lash-L, mind taking a look at this pull request as it has been labeled with an integration (snoo) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of snoo can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign snoo Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@dschafer
Copy link
Contributor Author

dschafer commented Oct 12, 2025

Given that this is for the Snoo integration, CC @Lash-L (and let me know if there's any changes you'd like me to make or any local testing that would be helpful here).

Edit: oops didn't know the bot would CC you, sorry for the double-CC.

@dschafer dschafer marked this pull request as ready for review October 12, 2025 03:27
@dschafer
Copy link
Contributor Author

In case it’s relevant to how we choose to display this state: the “Happiest Baby” app just shows it as “Baseline” (I guess the “weaning” is implied). I was loathe to completely hide that distinction within HA, hence going with “Baseline (Weaning)”.

IMG_0442

@joostlek joostlek added this to the 2025.10.3 milestone Oct 12, 2025
@joostlek joostlek merged commit 5978142 into home-assistant:dev Oct 12, 2025
34 checks passed
davidrecordon pushed a commit to davidrecordon/home-assistant-core that referenced this pull request Oct 12, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Oct 13, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants