Move developer url out of strings.json for coinbase setup flow #154339
Conversation
|
Hey there @TomBrien, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
There was a problem hiding this comment.
Pull Request Overview
This PR moves the Coinbase developer platform URL out of hardcoded strings in the translation file to a parameterized placeholder, improving translation maintainability by separating user-facing text from URLs that shouldn't be translated.
- Extracts developer URL from translated strings to avoid translation issues
- Adds URL as a description placeholder in the reauth confirmation flow
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| homeassistant/components/coinbase/strings.json | Updates reauth description to use {developer_url} placeholder instead of hardcoded URL |
| homeassistant/components/coinbase/config_flow.py | Adds developer_url parameter to description_placeholders in reauth flow |
| "reauth_confirm": { | ||
| "title": "Update Coinbase API credentials", | ||
| "description": "Your current Coinbase API key appears to be for the deprecated v2 API. Please reconfigure with a new API key created for the v3 API. Visit https://www.coinbase.com/developer-platform to create new credentials for {account_name}.", | ||
| "description": "Your current Coinbase API key appears to be for the deprecated v2 API. Please reconfigure with a new API key created for the v3 API.\nVisit {developer_url} to create new credentials for {account_name}.", |
There was a problem hiding this comment.
The newline ahead of the "Visist {developer_url}..." is to have the string not be weirdly cut between two lines.
Without newline:
With newline:
There was a problem hiding this comment.
You could use [Developer platform]({url}) instead to make it better readable
There was a problem hiding this comment.
If that is preferred, I will change it to that, just wasn't sure, since the original version had the full url visible and I wanted to keep 'continuity' so to speak.
There was a problem hiding this comment.
I think that is fine, it will look a lot better
Proposed change
This PR moves the url to the developer page for coinbase out of the
strings.jsonfile to help with translationType of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: