-
-
Notifications
You must be signed in to change notification settings - Fork 35.8k
Use async_schedule_reload instead of async_reload for ZHA
#154397
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use async_schedule_reload instead of async_reload for ZHA
#154397
Conversation
|
Hey there @dmulcahey, @Adminiuga, @TheJulianJES, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
|
We could also merge: #153685 Ps. But not for patch release |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good in general
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR replaces manual async_reload calls with async_schedule_reload in the ZHA integration to fix a race condition. The change prevents potential issues when multiple reload operations are triggered simultaneously by using Home Assistant's built-in scheduling mechanism.
Key Changes
- Removes manual task tracking and duplicate reload prevention logic
- Simplifies connection lost handling by using the safer
async_schedule_reloadmethod
Proposed change
async_schedule_reloadfixes a race condition that manually callingasync_reloadis susceptible to.Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: