Skip to content

Fix KNX climate loading min/max temp from UI config #155682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 3, 2025
Merged

Fix KNX climate loading min/max temp from UI config #155682

merged 1 commit into from
Nov 3, 2025

Conversation

@farmio
Copy link
Contributor

@farmio farmio commented Nov 2, 2025

Proposed change

  • Fix KNX climate loading min/max temp from UI config. This was using the wrong config key path.
  • Maintain order of hvac_modes.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

Copilot AI review requested due to automatic review settings November 2, 2025 17:13
@farmio farmio requested a review from marvin-w as a code owner November 2, 2025 17:13
@home-assistant
Copy link

home-assistant bot commented Nov 2, 2025

Hey there @Julius2342, @marvin-w, mind taking a look at this pull request as it has been labeled with an integration (knx) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of knx can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign knx Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@farmio farmio added this to the 2025.11.0 milestone Nov 2, 2025
Copilot AI reviewed Nov 2, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes the retrieval of min_temp and max_temp configuration values for KNX climate entities created via the UI, and ensures hvac_modes are returned in a consistent sorted order. The changes align the code with the nested structure of UI configuration data and improve test coverage by verifying additional entity attributes.

Key Changes

  • Fixed min_temp and max_temp to be read from the nested target_temperature configuration section instead of the root level
  • Added sorting to hvac_modes list to ensure consistent ordering
  • Enhanced test assertions to verify all major climate entity attributes

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
homeassistant/components/knx/climate.py Fixed config extraction path for min/max temperature and added sorting to hvac_modes
tests/components/knx/test_climate.py Added comprehensive attribute assertions to verify entity state values

@joostlek joostlek merged commit 1d0eb97 into dev Nov 3, 2025
41 of 42 checks passed
@joostlek joostlek deleted the knx-climate-ui-fix-min-temp branch November 3, 2025 00:35
bramkragten pushed a commit that referenced this pull request Nov 3, 2025
@farmio @bramkragten
Fix KNX climate loading min/max temp from UI config (#155682)
6616b57
@github-actions github-actions bot locked and limited conversation to collaborators Nov 4, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

Copilot code review Copilot Copilot left review comments

@joostlek joostlek joostlek approved these changes

@marvin-w marvin-w Awaiting requested review from marvin-w marvin-w is a code owner

Assignees

@marvin-w marvin-w

Labels

bugfix by-code-owner cherry-picked cla-signed has-tests integration: knx Quality Scale: silver small-pr PRs with less than 30 lines.

Projects

None yet

Milestone

2025.11.0

Development

Successfully merging this pull request may close these issues.

min_temp and max_temp of climate not saved

5 participants

@farmio @joostlek @marvin-w @bramkragten