Skip to content

Conversation

@synesthesiam
Copy link
Contributor

Breaking change

Proposed change

Use the language script code correctly when matching languages for voice.

Previously, sr would match sr-Latn (Latin characters) instead of just sr (Cyrillic) because the Latn code was not considered in the sorting when the requested language did not contain it.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request:

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant home-assistant bot added bugfix cla-signed core small-pr PRs with less than 30 lines. labels Nov 3, 2025
@synesthesiam synesthesiam marked this pull request as ready for review November 3, 2025 16:41
@synesthesiam synesthesiam requested a review from a team as a code owner November 3, 2025 16:41
@synesthesiam synesthesiam added this to the 2025.11.0 milestone Nov 3, 2025
@balloob balloob merged commit e09ec4a into dev Nov 3, 2025
62 checks passed
@balloob balloob deleted the synesthesiam-20251103-lang-match-code branch November 3, 2025 18:07
@github-actions github-actions bot locked and limited conversation to collaborators Nov 4, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants