-
-
Notifications
You must be signed in to change notification settings - Fork 36k
Remove arbitrary forecast limit for meteo_lt #155877
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes timezone handling and forecast data processing in the Meteo.lt weather integration. The changes ensure forecast timestamps include proper timezone information (Europe/Vilnius) and remove arbitrary limits on the number of forecasts returned.
Key changes:
- Added timezone conversion for all forecast timestamps using
ZoneInfo - Removed hardcoded limits on daily and hourly forecast counts
- Introduced helper method
_convert_api_timestamp_to_datetimefor consistent timestamp handling
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
|
I've reduced the scope for now as I'm still not 100% sure about the timestamp issue. I'll raise a new PR for it later on, let's just get the removal of limits merged for now. |
edenhaus
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @xE1H 👍
Breaking change
Proposed change
This PR fixes #155875. Not all data that was fetched from the API was converted to
Forecastobjects, it was truncated to 24h and 5d for hourly and daily, respectively.It also fixes a related issue -- timestamps not being converted to UTC for theForecastobject. It fixes the desync between the meteo.lt site and the integration due to incorrect timezone handling on the integration.I've reduced the scope for now as I'm still not 100% sure about the timestamp issue. I'll raise a new PR for it.
Type of change
Additional information
Please tag for 2025.11.1
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: