Skip to content

Conversation

@zweckj
Copy link
Member

@zweckj zweckj commented Nov 12, 2025

Breaking change

Proposed change

La Marzocco update dialogue is quitting too early, fix that

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request:

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@zweckj zweckj added this to the 2025.11.2 milestone Nov 12, 2025
Copilot AI review requested due to automatic review settings November 12, 2025 10:31
Copilot finished reviewing on behalf of zweckj November 12, 2025 10:32
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a bug in the La Marzocco firmware update process where the update dialog was exiting prematurely. The original loop condition only continued while the status was IN_PROGRESS, causing it to exit immediately when encountering other intermediate states like TO_UPDATE.

Key Changes

  • Modified the update loop to continue until status is UPDATED instead of only continuing while IN_PROGRESS
  • Updated test expectations to reflect that command_status will be UPDATED at completion rather than None

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
homeassistant/components/lamarzocco/update.py Changed loop condition from is UpdateStatus.IN_PROGRESS to is not UpdateStatus.UPDATED to prevent premature exit
tests/components/lamarzocco/test_update.py Updated test to expect command_status=UpdateStatus.UPDATED instead of None when update completes

@thecode thecode merged commit 14e41ab into home-assistant:dev Nov 12, 2025
41 of 42 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 13, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants