Skip to content

Conversation

@astrandb
Copy link
Contributor

Proposed change

Improve logging of failing action commands by adding http status code to relevant messages.

The background is that several users have contacted me recently about power on switches and light switches behaving weirdly. By adding the https error in messages we can blaim Miele this time. They respond 500 = "server failure" while they mostly accept the command and forward correct action to the appliance.

Please consider this enhancement for next patch release as it will simplify troubleshooting.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request:

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

frenck
frenck previously requested changes Nov 10, 2025
@home-assistant home-assistant bot marked this pull request as draft November 10, 2025 22:20
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@astrandb astrandb marked this pull request as ready for review November 10, 2025 23:03
@home-assistant home-assistant bot requested a review from frenck November 10, 2025 23:03
@astrandb
Copy link
Contributor Author

@zweckj @frenck Could you please take a look at my changes. Please also consider to add the PR to next patch release as it would simplify debugging for a API problem that is difficult to track down otherwise.

@zweckj
Copy link
Member

zweckj commented Nov 14, 2025

I think it’s reasonable to add it to the milestone. @frenck just remove it if you disagree

@zweckj zweckj merged commit 713015e into home-assistant:dev Nov 14, 2025
36 checks passed
@zweckj zweckj added this to the 2025.11.2 milestone Nov 14, 2025
@frenck frenck mentioned this pull request Nov 14, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Nov 15, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants