Skip to content

Conversation

@ptarjan
Copy link
Contributor

@ptarjan ptarjan commented Dec 10, 2025

Proposed change

The async_upnp_client library logs "Failed subscribing to service" at INFO level when UPnP subscriptions fail. These errors occur frequently when Samsung TVs (and other UPnP devices) are off or unreachable, creating noise in the logs. Since Home Assistant code already catches and handles these errors properly, suppress the library's verbose logging by setting its level to WARNING.

In my logs I'm seeing:

Logger: async_upnp_client.profiles.profile
Source: components/samsungtv/media_player.py:265
First occurred: December 9, 2025 at 9:44:23 PM (3 occurrences)
Last logged: December 9, 2025 at 9:45:09 PM

Failed subscribing to service: UpnpConnectionError('ClientConnectorError(ConnectionKey(host=\'192.168.1.22\', port=9197, is_ssl=False, ssl=True, proxy=None, proxy_auth=None, proxy_headers_hash=None), ConnectionRefusedError(111, "Connect call failed (\'192.168.1.22\', 9197)"))', None)
Failed subscribing to service: UpnpConnectionError("UpnpConnectionTimeoutError('TimeoutError()', None)", None)
Failed subscribing to service: UpnpConnectionError('ClientConnectorError(ConnectionKey(host=\'192.168.1.22\', port=9197, is_ssl=False, ssl=True, proxy=None, proxy_auth=None, proxy_headers_hash=None), OSError(113, "Connect call failed (\'192.168.1.22\', 9197)"))', None)

The fix is to bump async-upnp-client to 0.46.1, in which the log levels for these messages have been changed. Changes in async-upnp-client:

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request:

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@ptarjan ptarjan requested a review from a team as a code owner December 10, 2025 17:25
@home-assistant home-assistant bot added bugfix cla-signed core small-pr PRs with less than 30 lines. labels Dec 10, 2025
@ptarjan ptarjan force-pushed the claude/fix-upnp-subscription-error-01CEaCQcc11LSAtzf7YMKa88 branch from ac701ac to 095167e Compare December 10, 2025 17:40
ptarjan pushed a commit to ptarjan/async_upnp_client that referenced this pull request Dec 11, 2025
Reduce log noise by downgrading two INFO level messages to DEBUG:
- "No event_handler, event handling disabled"
- "Device rejected subscription request"

These messages are not actionable by users and cause excessive log
noise when devices are offline or unreachable. This addresses the
issue raised in home-assistant/core#158677.
StevenLooman pushed a commit to StevenLooman/async_upnp_client that referenced this pull request Dec 12, 2025
* Change subscription INFO logs to DEBUG level

Reduce log noise by downgrading two INFO level messages to DEBUG:
- "No event_handler, event handling disabled"
- "Device rejected subscription request"

These messages are not actionable by users and cause excessive log
noise when devices are offline or unreachable. This addresses the
issue raised in home-assistant/core#158677.

* Add towncrier changelog entry for logging change

* Rename changelog entry to use PR number 286

---------

Co-authored-by: Claude <noreply@anthropic.com>
@ptarjan ptarjan force-pushed the claude/fix-upnp-subscription-error-01CEaCQcc11LSAtzf7YMKa88 branch from 095167e to 90f768e Compare December 12, 2025 17:00
Copy link

@home-assistant home-assistant bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @claude

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft December 12, 2025 17:00
@ptarjan ptarjan force-pushed the claude/fix-upnp-subscription-error-01CEaCQcc11LSAtzf7YMKa88 branch from 90f768e to 458ab32 Compare December 12, 2025 17:01
@ptarjan ptarjan marked this pull request as ready for review December 12, 2025 17:01
This version includes a fix for verbose UPnP subscription error logs
that were noisy when devices (like Samsung TVs) are off or unreachable.
@ptarjan ptarjan force-pushed the claude/fix-upnp-subscription-error-01CEaCQcc11LSAtzf7YMKa88 branch from 458ab32 to f03a205 Compare December 12, 2025 17:56
Copy link
Contributor

@StevenLooman StevenLooman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joostlek joostlek added this to the 2025.12.4 milestone Dec 18, 2025
@joostlek joostlek merged commit dd6d739 into home-assistant:dev Dec 18, 2025
67 checks passed
@bramkragten bramkragten mentioned this pull request Dec 19, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Dec 20, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants