-
-
Notifications
You must be signed in to change notification settings - Fork 36.3k
Suppress verbose UPnP subscription error logs #158677
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
joostlek
merged 1 commit into
home-assistant:dev
from
ptarjan:claude/fix-upnp-subscription-error-01CEaCQcc11LSAtzf7YMKa88
Dec 18, 2025
Merged
Suppress verbose UPnP subscription error logs #158677
joostlek
merged 1 commit into
home-assistant:dev
from
ptarjan:claude/fix-upnp-subscription-error-01CEaCQcc11LSAtzf7YMKa88
Dec 18, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ac701ac to
095167e
Compare
epenet
reviewed
Dec 11, 2025
ptarjan
pushed a commit
to ptarjan/async_upnp_client
that referenced
this pull request
Dec 11, 2025
Reduce log noise by downgrading two INFO level messages to DEBUG: - "No event_handler, event handling disabled" - "Device rejected subscription request" These messages are not actionable by users and cause excessive log noise when devices are offline or unreachable. This addresses the issue raised in home-assistant/core#158677.
StevenLooman
pushed a commit
to StevenLooman/async_upnp_client
that referenced
this pull request
Dec 12, 2025
* Change subscription INFO logs to DEBUG level Reduce log noise by downgrading two INFO level messages to DEBUG: - "No event_handler, event handling disabled" - "Device rejected subscription request" These messages are not actionable by users and cause excessive log noise when devices are offline or unreachable. This addresses the issue raised in home-assistant/core#158677. * Add towncrier changelog entry for logging change * Rename changelog entry to use PR number 286 --------- Co-authored-by: Claude <noreply@anthropic.com>
095167e to
90f768e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
90f768e to
458ab32
Compare
This version includes a fix for verbose UPnP subscription error logs that were noisy when devices (like Samsung TVs) are off or unreachable.
458ab32 to
f03a205
Compare
StevenLooman
approved these changes
Dec 12, 2025
Contributor
StevenLooman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
joostlek
approved these changes
Dec 18, 2025
bramkragten
pushed a commit
that referenced
this pull request
Dec 19, 2025
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
The async_upnp_client library logs "Failed subscribing to service" at INFO level when UPnP subscriptions fail. These errors occur frequently when Samsung TVs (and other UPnP devices) are off or unreachable, creating noise in the logs. Since Home Assistant code already catches and handles these errors properly, suppress the library's verbose logging by setting its level to WARNING.
In my logs I'm seeing:
The fix is to bump
async-upnp-clientto0.46.1, in which the log levels for these messages have been changed. Changes inasync-upnp-client:Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: