Fix Sonos speaker async_offline assertion failure #158764
Merged
+35
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey there @jjlawren, @PeteRager, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
8fff783 to
45ae553
Compare
kmk142789
approved these changes
Dec 12, 2025
PeteRager
suggested changes
Dec 12, 2025
Contributor
PeteRager
left a comment
There was a problem hiding this comment.
Tests should not access internals
0fbc440 to
f601acd
Compare
Handle the case where async_offline() is called before async_subscribe() has been invoked, which would leave _subscription_lock as None. This can happen during shutdown when a speaker was discovered but no activity was detected yet. Instead of asserting, create the lock if it doesn't exist, matching the existing pattern in async_subscribe().
Tests the fix for the AssertionError when async_offline() is called on a speaker where _subscription_lock is None (e.g., when a speaker is discovered but no activity was detected before shutdown).
f601acd to
5a464bc
Compare
PeteRager
reviewed
Dec 12, 2025
Ensure all background tasks complete before checking results in the async_offline_without_subscription_lock test.
Patching async_setup ensures the subscription lock is never created, since async_subscribe (which creates the lock) is called from async_setup.
Instead of patching the integration, configure the SoCo mock's play_mode property to raise SoCoException. This causes setup() to fail early (before scheduling async_setup), leaving the speaker in discovered without _subscription_lock being created.
joostlek
approved these changes
Dec 18, 2025
bramkragten
pushed a commit
that referenced
this pull request
Dec 19, 2025
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle the case where async_offline() is called before async_subscribe() has been invoked, which would leave _subscription_lock as None. This can happen during shutdown when a speaker was discovered but no activity was detected yet. Instead of asserting, create the lock if it doesn't exist, matching the existing pattern in async_subscribe().
Failed in: https://github.com/home-assistant/core/actions/runs/20151776328/job/57846433236
Breaking change
Proposed change
Root cause: In SonosSpeaker:
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: