Skip to content

Conversation

@pantherale0
Copy link
Contributor

@pantherale0 pantherale0 commented Dec 9, 2025

Proposed change

As above, in this version all of the authentication related code has been split out into a pynintendoauth library to make it easier to maintain (especially as there could be a Nintendo Switch Online integration on the way which will rely on the same auth code) hence the major version bump.

This new dependency is included in the library configuration as a compatible release (https://peps.python.org/pep-0440/#compatible-release).

That being said this is the only change in this version. A summary of the changes (courtesy of Gemini) is available here pantherale0/pynintendoparental#54 (comment)

You will see a number of methods have been renamed (eg get_session_token is now just session_token and complete_login is no longer a class method and instead a standard async function called async_complete_login).

This has been fully tested locally.

Release: https://github.com/pantherale0/pynintendoparental/releases/tag/2.0.0
Diff: pantherale0/pynintendoparental@1.1.3...2.0.0

Related lib https://github.com/pantherale0/pynintendoauth:

Release: https://github.com/pantherale0/pynintendoauth/releases/tag/1.0.0
Diff: Not available

Required to complete #155786

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request:

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

Copy link
Member

@zweckj zweckj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zweckj zweckj merged commit 88c7c6f into home-assistant:dev Dec 9, 2025
67 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 10, 2025
@abmantis abmantis added this to the 2025.12.4 milestone Dec 16, 2025
@abmantis
Copy link
Member

Milestone added since it is needed for #159120

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants