Skip to content

Watson-TTS - Missing comma preventing other voices being used. #24487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
balloob merged 1 commit into from
Jun 12, 2019
Merged

Watson-TTS - Missing comma preventing other voices being used. #24487

balloob merged 1 commit into from
Jun 12, 2019

Conversation

@aidbish
Copy link
Contributor

@aidbish aidbish commented Jun 11, 2019 •
edited
Loading

The comma was missing for one of the listed voices in the new watson_tts component. This was preventing it and the next one from being a valid voice in configuration.

Invalid config for [tts.watson_tts]: value is not allowed for dictionary value @ data['voice']. Got 'en-GB_KateVoice'. (See /config/configuration.yaml, line 96). Please check the docs at https://home-assistant.io/components/tts.watson_tts/
Connection lost. Reconnecting…

Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>
Not required

Example entry for configuration.yaml (if applicable):

NA

## Checklist:
  - [ ] The code change is tested and works locally.
  - [ ] Local tests pass with `tox`. **Your PR cannot be merged unless tests pass**
  - [ ] There is no commented out code in this PR.
  - [ ] I have followed the [development checklist][dev-checklist]

If user exposed functionality or configuration variables are added/changed:
  - [ ] Documentation added/updated in [home-assistant.io](https://github.com/home-assistant/home-assistant.io)

If the code communicates with devices, web services, or third-party tools:
  - [ ] [_The manifest file_][manifest-docs] has all fields filled out correctly. Update and include derived files by running `python3 -m script.hassfest`.
  - [ ] New or updated dependencies have been added to `requirements_all.txt` by running `python3 -m script.gen_requirements_all`.
  - [ ] Untested files have been added to `.coveragerc`.

If the code does not interact with devices:
  - [ ] Tests have been added to verify that the new code works.

[dev-checklist]: https://developers.home-assistant.io/docs/en/development_checklist.html
[manifest-docs]: https://developers.home-assistant.io/docs/en/creating_integration_manifest.html

@ghost
Copy link

ghost commented Jun 11, 2019

Hey there @rutkai, mind taking a look at this pull request as its been labeled with a integration (watson_tts) you are listed as a codeowner for? Thanks!

This is a automatic comment generated by codeowners-mention to help ensure issues and pull requests are seen by the right people.

@aidbish aidbish changed the title missing comma preventing other voices Watson-TTS - Missing comma preventing other voices being used. Jun 12, 2019
@balloob balloob added this to the 0.94.3 milestone Jun 12, 2019
@balloob balloob merged commit 4c328e4 into home-assistant:dev Jun 12, 2019
@aidbish aidbish deleted the patch-1 branch June 12, 2019 22:21
balloob pushed a commit that referenced this pull request Jun 13, 2019
@aidbish @balloob
missing comma preventing other voices (#24487)
7260cad
@balloob balloob mentioned this pull request Jun 13, 2019
Merged
alandtse pushed a commit to alandtse/home-assistant that referenced this pull request Oct 12, 2019
@aidbish @alandtse
missing comma preventing other voices (home-assistant#24487)
3701f0a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Kane610 Kane610 Kane610 approved these changes

Assignees

No one assigned

Labels

cherry-picked cla-signed integration: watson_tts small-pr PRs with less than 30 lines.

Projects

None yet

Milestone

0.94.3

Development

Successfully merging this pull request may close these issues.

4 participants

@aidbish @Kane610 @balloob @homeassistant