Skip to content

Conversation

@farmio
Copy link
Contributor

@farmio farmio commented Jul 20, 2019

Description:

This is a temporary patch for knx climate devices. It should be reverted when #24738 is merged to release.

Related issue (if applicable): It should fix #25247 for 0.96

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

This is a temporary patch for knx climate devices. It should be reverted when home-assistant#24738 is merged to release. 
It should fix home-assistant#25247 for 0.96
@ghost
Copy link

ghost commented Jul 20, 2019

Hey there @Julius2342, mind taking a look at this pull request as its been labeled with a integration (knx) you are listed as a codeowner for? Thanks!

This is a automatic comment generated by codeowners-mention to help ensure issues and pull requests are seen by the right people.

@balloob
Copy link
Member

balloob commented Jul 21, 2019

Thanks !

@balloob balloob merged commit 0143026 into home-assistant:rc Jul 21, 2019
@balloob balloob mentioned this pull request Jul 21, 2019
@lock lock bot locked and limited conversation to collaborators Jul 22, 2019
@farmio farmio deleted the patch-1 branch July 23, 2019 18:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla-signed integration: knx small-pr PRs with less than 30 lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants