Improve Vizio fix to avoid KeyError #32163
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #32163 +/- ##
==========================================
- Coverage 94.74% 94.73% -0.01%
==========================================
Files 768 768
Lines 55629 55619 -10
==========================================
- Hits 52703 52693 -10
Misses 2926 2926
Continue to review full report at Codecov.
|
balloob
pushed a commit
that referenced
this pull request
Feb 25, 2020
* dont set default volume_step on import check * ensure config entry data['volume_step'] is set * consolidate entry update during entry setup
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
In #32151 I fixed a bug that occurred when the config entry data dictionary did not have
volume_step. @MartinHjelmare identified that the change I made was redundant in that I was falling back to the DEFAULT_VOLUME_STEP when checking the config, but that is unnecessary because config validation already guarantees that thevolume_stepparameter is in the config dictionary, so this change fixes that. As part of looking into this, I also realized that I did not setvolume_stepin the data dictionary on initialization, which means that the second import (e.g. on a restart) would always set it. I have updated the logic to always ensure it is included in the config entry data.This should go out with 0.106 along with the other linked PR
Type of change
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale: