Add coronavirus integration #32413
Merged
Add coronavirus integration #32413
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frenck
reviewed
Mar 2, 2020
Co-Authored-By: Franck Nijhof <git@frenck.dev>
balloob
added a commit
that referenced
this pull request
Mar 2, 2020
* Add coronavirus integration * Update homeassistant/components/coronavirus/manifest.json Co-Authored-By: Franck Nijhof <git@frenck.dev> Co-authored-by: Franck Nijhof <frenck@frenck.nl>
Merged
7 tasks
|
Can we improve the default naming (entity_ids) of the generated sensors? sensor.worldwide_current isn't that descriptive. |
|
Yeah we can. What do you suggest? |
|
Good question. Prefixing with corona_ works I guess? And maybe append something like _cases? So you get |
|
coronavirus then, to not conflate things. We influence the entity ID by updating the name, so we will end up updating the name then, which will reflect into updated entity IDs for new users of the integration. |
|
Thinking that if we shuffle it around, we can drop the word "cases"
|
|
Downside is that the badges are going to look bad. Current: |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
Add support for monitoring the coronovirus outbreak.
Type of change
Example entry for
configuration.yaml:# Example configuration.yamlAdditional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale: