[feature] Add Attribute and OnlyChild traits #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pbougue
reviewed
Apr 16, 2020
669c36b to
f849d2c
Compare
pbougue
reviewed
Apr 16, 2020
d37f888 to
ea876e5
Compare
pbougue
approved these changes
Apr 16, 2020
Contributor
pbougue
left a comment
There was a problem hiding this comment.
Not super confident on my review for technical minidom and Rust part, though :)
Contributor
Author
|
For information, I changed |
Contributor
Author
|
I just did some homogeneization about license in this project in 3853258. |
3853258 to
81259e1
Compare
datanel
approved these changes
Apr 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The build of this branch can be checked on https://github.com/woshilapin/minidom_ext/actions/runs/79047305.