Add support for dynamic labels (where the value is obtained from tracing fields) #28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sing open categories.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For a project I'm working on I needed to set labels based on tracing fields. This PR adds support for that (as "dynamic labels") gated behind a default feature. When the feature is disabled, the execution flow is almost unchanged. The code has been tested inside an application both with the feature enabled and disabled and performs as expected.
A single unrelated change here is making the bounded event queue quite a bit larger, into "you have bigger problems if you overflow this" territory - i just found the initial value a bit restrictive. I can remove / split this change into a separate PR if you consider it appropriate.